[Regression pre-wmf.4] A solid black icon appearing over an image after selecting it inside the Media Settings dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Oct 17 2017, 5:46 PM

Description

Steps to reproduce:

Go to Insert>Media
Search for any image.
Select it

Observed Result:

There is a solid black icon appearing over the image

See the screenshot attached

Screen Shot 2017-10-17 at 12.45.39 PM.png (689×1 px, 661 KB)

Details

	Subject	Repo	Branch	Lines +/-
	ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons	mediawiki/extensions/VisualEditor	wmf/1.31.0-wmf.4	+1 -0
	ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons	mediawiki/extensions/VisualEditor	master	+1 -0

Customize query in gerrit

Event Timeline

Ryasmeen created this task.Oct 17 2017, 5:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2017, 5:46 PM

matmarex claimed this task.Oct 17 2017, 5:52 PM

• Deskana triaged this task as High priority.Oct 17 2017, 5:52 PM

• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

• Deskana set the point value for this task to 1.

Change 384730 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.yu.MWMediaInfoFieldWidget: Fix positioning of icons

https://gerrit.wikimedia.org/r/384730

gerritbot added a project: Patch-For-Review.Oct 17 2017, 5:55 PM

The "solid black icon" is a result of overlaying all the grey icons normally shown in the dialog on top of each other:

This will need to be backported to 1.31.0-wmf.4.

Change 384730 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons

https://gerrit.wikimedia.org/r/384730

Change 384748 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.4] ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons

https://gerrit.wikimedia.org/r/384748

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 17 2017, 7:00 PM

• Deskana closed this task as Resolved.Oct 17 2017, 9:40 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 17 2017, 9:40 PM

Ryasmeen edited projects, added Verified; removed Patch-For-Review.Oct 17 2017, 9:42 PM

Change 384748 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.4] ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons

https://gerrit.wikimedia.org/r/384748

Mentioned in SAL (#wikimedia-operations) [2017-10-17T23:29:05Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.4/extensions/VisualEditor/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaInfoFieldWidget.css: SWAT: [[gerrit:384748|ve.ui.MWMediaInfoFieldWidget: Fix positioning of icons]] T178415 (duration: 00m 50s)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)); removed MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 18 2017, 12:00 AM

Ryasmeen added a project: Verified-in-Phase0.Oct 18 2017, 8:11 PM

	F10279756: Screen Shot 2017-10-17 at 12.45.39 PM.png
	Oct 17 2017, 5:46 PM

	F10279784: image.png
	Oct 17 2017, 5:57 PM

[Regression pre-wmf.4] A solid black icon appearing over an image after selecting it inside the Media Settings dialog Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

[Regression pre-wmf.4] A solid black icon appearing over an image after selecting it inside the Media Settings dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions