Page MenuHomePhabricator

Update UploadWizard with legal language/UI for 3D files
Closed, ResolvedPublic

Description

Implement new design for UploadWizard that reflects the following:

  • Legal language prohibiting upload of weapons depicted in 3D files
  • User agreements to Patent Warranty for objects depicted in 3D files
  • User agreement to Patent License for objects depicted in 3D files

Designs for these adjustments are located at: https://wikimedia.invisionapp.com/share/7VDBAJVSN#/screens/251552642_0

Details

Related Gerrit Patches:
mediawiki/extensions/UploadWizard : masterAdd patent license agreement

Event Timeline

Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

Change 386413 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] [WIP] Add patent license agreement

https://gerrit.wikimedia.org/r/386413

I have a mostly done patch - just have a few more questions:

https://wikimedia.invisionapp.com/share/7VDBAJVSN#/screens/251552644

  • I changed the location of the "I, <input>, would like to grant..." bit slightly: it is now below the "Use a different license" link (which is additional functionality linked to the "I, <input>, the copyright holder..." piece.
    • Is that ok?
  • "I, <input>, would like to grant a permanent patent license to any users of the file and related 3D objects (legal code)."
    • Where should "legal code" link to?
  • Can the names in both input boxes (copyright holder & patent license granter) be different, or should it be made so that changing one also updates the other and they are always the same?
  • Under "This file is not my own work", only the CC & Flickr - is that intentional, or should the others (copyright expired, US Gov, other reason, found on internet) be kept?

https://wikimedia.invisionapp.com/share/7VDBAJVSN#/screens/251552640

  • Where do both "Learn more" links link to?

https://wikimedia.invisionapp.com/share/7VDBAJVSN#/screens/251552645

  • Not shown on mockup, but it is possible for the license stuff to be selected individually in this step, if there were multiple uploads.
    • I assumed we only want the confirmation dialog to show up once, even if there are multiple 3D file uploads - is that correct?

After upload

  • What wikitext needs to be generated? I assume we'll want to add something similar to the license information (e.g. =={{int:license-header}}==\n{{self|cc-by-sa-4.0}})

Another question: the "Patent rights" dialog looks different in the "This file is my own work" vs the "This file is not my own work" version (the second does not have the "patent license" paragraph)
If a user uploads multiple 3D files and selects "Provide copyright information for each file individually on the next page." in the release rights step, he can choose different licenses per file in next step.
In such a case, what do we want:

  • 1 dialog per upload (I assume this gets annoying, having to click through multiple dialogs)
  • 1 combined dialog:
    • Which?
      • We probably don't want to omit the patent license paragraph if there are any such uploads
      • The patent license paragraph seems confusing when some of the files are not their own work
    • Do we need to alter the dialog shown in such case when there are uploads, some of which are own works and others which are not?
  • Another new dialog with different wording for when the upload are a mix of own and other works?

Hi @matthiasmullie . Responses to your questions:

I changed the location of the "I, <input>, would like to grant..." bit slightly: it is now below the "Use a different license" link (which is additional functionality linked to the "I, <input>, the copyright holder..." piece.

Yes, this is good.

"I, <input>, would like to grant a permanent patent license to any users of the file and related 3D objects (legal code)."
Where should "legal code" link to?

We have just received legal text for this. It will be placed on a Foundation wiki page, but we don't have the link yet. But for the Weapons policy link, use: https://meta.wikimedia.org/wiki/Wikilegal/3D_files_and_3D_printing#Weapons. All other Learn More links should go to: https://meta.wikimedia.org/wiki/Wikilegal/3D_files_and_3D_printing

Can the names in both input boxes (copyright holder & patent license granter) be different, or should it be made so that changing one also updates the other and they are always the same?

They are always the same. If one changes, the other should too.

Under "This file is not my own work", only the CC & Flickr - is that intentional, or should the others (copyright expired, US Gov, other reason, found on internet) be kept?

This was not intentional. The other options should be kept.

What wikitext needs to be generated? I assume we'll want to add something similar to the license information

At the moment there's no new wikitext to be generated, just the standard licensing stuff. In that regard, treat it as any other file.

If a user uploads multiple 3D files and selects "Provide copyright information for each file individually on the next page." in the release rights step, he can choose different licenses per file in next step.
In such a case, what do we want:

Although it's annoying, asking the user to deal with the popup each time is the best we can do for now in this case.

If a user uploads multiple 3D files and selects "Provide copyright information for each file individually on the next page." in the release rights step, he can choose different licenses per file in next step.
In such a case, what do we want:

Although it's annoying, asking the user to deal with the popup each time is the best we can do for now in this case.

It's more than just annoying: these dialogs also don't have context - they just appear. If there are multiple dialogs right after one another (when submitting the uploads), it is unclear which dialog belongs to which file, making it a very confusing experience.

Ainali added a subscriber: Ainali.Nov 2 2017, 4:01 PM
Johan awarded a token.Nov 2 2017, 4:06 PM

One last thing: where does that "no weapons" icon come from? @Nirzar can you link me to that icon?

@matthiasmullie I can provide the "no weapons" icon for you - SVG?

That was the one, thanks!

Change 386413 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Add patent license agreement

https://gerrit.wikimedia.org/r/386413

ABorbaWMF closed this task as Resolved.Nov 27 2017, 6:41 PM
ABorbaWMF added a subscriber: ABorbaWMF.

Looking good on Beta.