Page MenuHomePhabricator
Create Task
Maniphest T178522

Another searchmatch span altering searches
Closed, ResolvedPublic
Actions

Description

After T173172 was resolved, </span> tags started to appear in the results as expected. However, another trouble showed up: when the search match is contained within a section title, it is still wrapped in a searchmatch span, being even nastier than the already corrected ones. In fact, this time it is considered as part of the link and the link to the section itself is corrupted. Take this search: https://it.wikipedia.org/w/index.php?title=Speciale:Ricerca&profile=all&search=%22spazio+unificatore+come+se+piovesse%22&fulltext=1&searchToken=6cwj3dydyftxsype3vw2fwczd
the 2nd result is a match in a section title. However, the bold link includes the whole span (actually more than one) and it doesn't lead to any section because of this.

Details

SubjectRepoBranchLines +/-
Strip highlighting before converting to htmlmediawiki/extensions/CirrusSearchwmf/1.31.0-wmf.5+49 -29
Strip highlighting before converting to htmlmediawiki/extensions/CirrusSearchwmf/1.31.0-wmf.4+49 -29
Strip highlighting before converting to htmlmediawiki/extensions/CirrusSearchmaster+49 -29
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Oct 18 2017, 6:30 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptOct 18 2017, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Daimona triaged this task as High priority.Oct 19 2017, 7:54 AM

Triaging as high since it's almost the same as the other task (triaged as high) but this time it may cause bigger troubles, even to a "normal user" who doesn't care about </span>.

debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.Oct 19 2017, 5:03 PM
debt subscribed.Oct 25 2017, 4:16 PM

Once this work is done, it should also fix T178991 (closing for being a dupe).

debt mentioned this in T178991: Span in url in search results.Oct 25 2017, 4:16 PM
Sunpriat2 subscribed.Oct 25 2017, 5:24 PM
EBernhardson claimed this task.Oct 25 2017, 8:38 PM
EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot subscribed.Oct 25 2017, 9:03 PM

Change 386521 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Strip highlighting before converting to html

https://gerrit.wikimedia.org/r/386521

gerritbot added a project: Patch-For-Review.Oct 25 2017, 9:03 PM
MaxSem merged a task: T178991: Span in url in search results.Oct 25 2017, 9:33 PM
MaxSem added subscribers: Oshwah, kaldari, MaxSem, Johan.
EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Oct 25 2017, 10:40 PM
gerritbot added a comment.Oct 26 2017, 12:42 AM

Change 386521 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Strip highlighting before converting to html

https://gerrit.wikimedia.org/r/386521

Nonenmac subscribed.Oct 26 2017, 8:16 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)).Oct 30 2017, 4:01 PM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Oct 30 2017, 10:21 PM
gerritbot added a comment.Oct 30 2017, 10:22 PM

Change 387440 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@wmf/1.31.0-wmf.4] Strip highlighting before converting to html

https://gerrit.wikimedia.org/r/387440

gerritbot added a comment.Oct 30 2017, 10:23 PM

Change 387441 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@wmf/1.31.0-wmf.5] Strip highlighting before converting to html

https://gerrit.wikimedia.org/r/387441

gerritbot added a comment.Oct 30 2017, 11:10 PM

Change 387440 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.31.0-wmf.4] Strip highlighting before converting to html

https://gerrit.wikimedia.org/r/387440

gerritbot added a comment.Oct 30 2017, 11:16 PM

Change 387441 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.31.0-wmf.5] Strip highlighting before converting to html

https://gerrit.wikimedia.org/r/387441

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)); removed MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)).Oct 31 2017, 12:00 AM
debt closed this task as Resolved.Nov 9 2017, 10:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL