Page MenuHomePhabricator
Create Task
Maniphest T178532

[Regression pre-wmf.5] The icon for switch to Visual editing is missing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open VE/NWE
  2. Open the Editor switcher

Observe that, the icon for switch to Visual editing is missing

Screen Shot 2017-10-18 at 3.35.55 PM.png (595×1 px, 192 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix switcher icon dependenciesmediawiki/extensions/VisualEditormaster+1 -1
Account for 'eye' icon having moved icon packsmediawiki/extensions/VisualEditormaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Oct 18 2017, 8:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2017, 8:38 PM
gerritbot subscribed.Oct 18 2017, 10:52 PM

Change 385109 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix switcher icon dependencies

https://gerrit.wikimedia.org/r/385109

gerritbot added a project: Patch-For-Review.Oct 18 2017, 10:52 PM
gerritbot added a comment.Oct 19 2017, 5:18 PM

Change 385212 had a related patch set uploaded (by Bartosz Dziewoński; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Account for 'eye' icon having moved icon packs

https://gerrit.wikimedia.org/r/385212

gerritbot added a comment.Oct 19 2017, 5:19 PM

Change 385109 abandoned by Bartosz Dziewoński:
Fix switcher icon dependencies

Reason:
Included in https://gerrit.wikimedia.org/r/#/c/385212/

https://gerrit.wikimedia.org/r/385109

gerritbot added a comment.Oct 19 2017, 5:28 PM

Change 385212 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Account for 'eye' icon having moved icon packs

https://gerrit.wikimedia.org/r/385212

gerritbot added a comment.Oct 19 2017, 5:29 PM

Change 385109 restored by Jforrester:
Fix switcher icon dependencies

Reason:
Actually, I didn't do this one (we use the eye icon for visual diffs as compared to wikitext, and for visual editing as compared to wikitext). This is for the latter, the other is for the former.

https://gerrit.wikimedia.org/r/385109

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Oct 19 2017, 5:32 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 19 2017, 6:00 PM
gerritbot added a comment.Oct 19 2017, 6:05 PM

Change 385109 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix switcher icon dependencies

https://gerrit.wikimedia.org/r/385109

• Deskana closed this task as Resolved.Oct 19 2017, 7:41 PM
• Deskana assigned this task to Esanders.
• Deskana set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 19 2017, 7:41 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Patch-For-Review.Oct 19 2017, 9:30 PM
Ryasmeen added a project: Verified.Oct 19 2017, 9:38 PM
Schnark mentioned this in T202805: Improve process of deprecating icons in OOUI.Aug 25 2018, 9:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits