Change 385152 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] Draft: Setting a multi-instance host

https://gerrit.wikimedia.org/r/385152

Anyone would be able to review the patch so we can move forward with splitting wikidata from s5 into its own shard (s8)?.
It would be good to start having a clear picture of how codfw will look like in regard with the server allocation

Thanks!

Change 386810 had a related patch set uploaded (by Marostegui; owner: Marostegui):
[operations/mediawiki-config@master] db-codfw.php: Pool db2084 as multi-instance host

https://gerrit.wikimedia.org/r/386810

I would like to deploy: https://gerrit.wikimedia.org/r/#/c/386810/ next week, can I get someone else apart from @Anomie (thanks!) to check it.
I would feel more comfortable

cc @tstarling @aaron @Reedy maybe?

I'm not very familiar with the beta-side of wmf-config, but from a quick look it seems to me that db-labs.php is used there.
To be on the safe side, could we apply this first in deployment-prep adding the :3306 to some of the DBs and verify that everything is still working as expected? Will this test the same code branches that will be used once in production?

In T178553#3715246, @Volans wrote:

I'm not very familiar with the beta-side of wmf-config, but from a quick look it seems to me that db-labs.php is used there.
To be on the safe side, could we apply this first in deployment-prep adding the :3306 to some of the DBs and verify that everything is still working as expected? Will this test the same code branches that will be used once in production?

FWIW, appending :3306 to $wgDBserver on my dev wiki makes no obvious difference

A quick dig into the code, and on the MySQLi wrapper, we cater for this 'hosname:port' pattern already

		$hostAndPort = IP::splitHostAndPort( $realServer );
		if ( $hostAndPort ) {
			$realServer = $hostAndPort[0];
			if ( $hostAndPort[1] ) {
				$port = $hostAndPort[1];
			}
		}

And we use DatabaseMysqli in WMF production too. Yay.

For the the older non mysqli wrapper, the PHP docs say this should work too

* @param string $server [optional] <p>
* The MySQL server. It can also include a port number. e.g. 
* "hostname:port" or a path to a local socket e.g. ":/path/to/socket" for 
* the localhost.

So... I'd be pretty sure this will work. Per @Volans we could just append ports to all servers (for consistency), on beta, and then deploy it and see ;). Or cherry pick it to deployment-tin (sync-common maybe? I can never remember), and use mwscript sql.php --wiki=enwiki and do a simple query and check it doesn't just break

Thanks @Reedy for checking this! :-)
Would you be able to quickly check it on beta? (I have never deployed/used beta so it might take me even more to figure it out than to actually test it!) :-)

Thanks @Reedy @Anomie and @tstarling for reviewing the patches, really appreciated.
As the three of you are really confident this should work, I will try to deploy it during this week early in the morning (and only for codfw) and leave it like that for a few day!
Thanks again - I will notify here once it is deployed

Change 387229 had a related patch set uploaded (by Reedy; owner: Reedy):
[operations/mediawiki-config@master] Add port numbers to beta db servers

https://gerrit.wikimedia.org/r/387229

Change 387229 merged by jenkins-bot:
[operations/mediawiki-config@master] Add port numbers to beta db servers

https://gerrit.wikimedia.org/r/387229

Beta is still working after that patch being deployed

In T178553#3719274, @Reedy wrote:

Beta is still working after that patch being deployed

Thank you!! :-)

Change 386810 merged by jenkins-bot:
[operations/mediawiki-config@master] db-codfw.php: Pool db2084 as multi-instance host

https://gerrit.wikimedia.org/r/386810

Mentioned in SAL (#wikimedia-operations) [2017-10-31T09:12:27Z] <marostegui@tin> Synchronized wmf-config/db-codfw.php: Pool db2084 as multi-instance core host T178553 T178359 (duration: 00m 49s)

Change 385152 abandoned by Marostegui:
Draft: Setting a multi-instance host

Reason:
This was a draft that is no longer needed as the proper patch has been merged and deployed here: https://gerrit.wikimedia.org/r/#/c/386810/

Thanks Anomie for reviewing it!

https://gerrit.wikimedia.org/r/385152

Mentioned in SAL (#wikimedia-operations) [2017-11-06T06:46:10Z] <marostegui@tin> Synchronized wmf-config/db-codfw.php: Add db2084 as multi-instance core host on eqiad file T178553 T178359 (duration: 00m 46s)

Mentioned in SAL (#wikimedia-operations) [2017-11-06T09:25:39Z] <marostegui@tin> Synchronized wmf-config/db-eqiad.php: Add db2085 as multi-instance core host on eqiad file T178553 T178359 (duration: 00m 46s)

Mentioned in SAL (#wikimedia-operations) [2017-11-06T09:26:47Z] <marostegui@tin> Synchronized wmf-config/db-eqiad.php: Pool db2085 as recentchanges multi-instance host on s3 and s5 T178553 T178359 (duration: 00m 46s)