Page MenuHomePhabricator

Mention global JS in NavPopups conflict message
Closed, ResolvedPublic0.5 Estimated Story Points

Description

Context

After T178438#3696251, @Elitre and I spent a little while debugging why Page Previews wasn't detecting that the NavPopups gadget was enabled. Per T178438#3696349, it turned out that the gadget was enabled in their global.js on metawiki.

AC

  • The popups-prefs-conflicting-gadgets-info message explicitly mentions gadgets loaded via a user's global JS.

Event Timeline

ovasileva triaged this task as Medium priority.Oct 19 2017, 2:56 PM

@phuedx - currently, the message reads: "Certain gadgets and other customizations may affect the performance of this feature. If you experience problems please review your gadgets and user scripts." I think that covers this case as well.

@ovasileva: I don't see any harm in explicitly calling out NavPopups here (I'm assuming by "may affect the performance of this feature" we mean "will conflict with this feature"), nor do I see an issue with linking to https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#Personal_scripts.

How about "Certain gadgets and other customizations may affect the performance of this feature. If you experience problems please review your gadgets and user scripts: (https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#Personal_scripts). In particular, users may experience issues with the NavPopups gadget."

ovasileva set the point value for this task to 0.5.Oct 31 2017, 4:14 PM

Suggestion: "Certain gadgets and other customizations may affect the performance of this feature. If you experience problems please review your gadgets and user scripts, including global ones".

The entire point of this task is that it didn't even occur to me that there was a global thing that I had set up and that I should have checked.

Change 387751 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Update gadget warning to mention global gadgets

https://gerrit.wikimedia.org/r/387751

Jdlrobson added a subscriber: Jdlrobson.

^ This change is pretty trivial. Does @Elitre's copy look good?

I'll be bold and merge the copy and move it to sign off. Changing the copy is trivial so if we want to add something/change sth it won't be a problem.

Change 387751 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Update gadget warning to mention global gadgets

https://gerrit.wikimedia.org/r/387751

Looks good to me. Do we know where we can test this?

@ovasileva - go to Preferences Page / Apperance (https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rendering), then on Reading preferences section page previews description will contain the updated copy.

Screenshot from 2017-11-01 13-10-14.png (183×736 px, 19 KB)