Page MenuHomePhabricator

Add require_package() variant with repository component to wmflib
Closed, DeclinedPublic

Description

We currently have require_package() which ensures that a package(s) are installed before the rest of the class is evaluated.

It would be great to have an additional function like require_package_in_repo($package, $repository) which ensures that before installing the package(s) Apt::Repository($repository) is added and an Exec['apt-get update'] is run. This will be increasingly needed with the new repository layout.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2017, 2:18 PM
elukey added a subscriber: elukey.Oct 20 2017, 3:52 PM
MoritzMuehlenhoff triaged this task as Medium priority.Nov 13 2017, 7:34 AM
herron added a subscriber: herron.Apr 8 2019, 1:55 PM

Since today we have a mix of package and require_package this would be very nice indeed. Does it need to be homegrown? Seems worthwhile to weigh the pros/cons of using native Puppet ordering as well.

MoritzMuehlenhoff closed this task as Declined.Feb 14 2020, 3:59 PM

With package_from_component() I don't think we need this any longer, it serves a similar purpose and proper dependencies can be defined.