Page MenuHomePhabricator

HAWelcome has some outstanding TODO's that make the extension not yet usable outside ShoutWiki
Closed, ResolvedPublic

Description

From the commit message of rEHAWca43438211d194749715fc541334ed9c030f098c:

  • Should not hardcode in the welcomer name (currently hardcoded to "ShoutWiki" in HAWelcome.class.php)
  • Staff user rights are fetched from global_user_groups table which exists only if [[Extension:GlobalUserrights]] is installed (as it is on ShoutWiki); the extension should take into account that it's possible the DB table does not exist
    • A dependency on GlobalUserrights has been added in 3f939e8b7eab for the time being
  • Support for expiring user rights? (new feature in MW 1.29)
  • Review Wikia and wikiHow patches to HAWelcome and incorporate the useful changes not specific to their codebases

Event Timeline

Change 385219 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/extensions/HAWelcome@master] Add a hard dependency on GlobalUserrights

https://gerrit.wikimedia.org/r/385219

Change 385219 merged by Jack Phoenix:
[mediawiki/extensions/HAWelcome@master] Add a hard dependency on GlobalUserrights

https://gerrit.wikimedia.org/r/385219

Mainframe98 triaged this task as Medium priority.
Mainframe98 updated the task description. (Show Details)

Change 385805 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/extensions/HAWelcome@master] Rework and improve HAWelcome

https://gerrit.wikimedia.org/r/385805

Change 385805 merged by Jack Phoenix:
[mediawiki/extensions/HAWelcome@master] Rework and improve HAWelcome

https://gerrit.wikimedia.org/r/385805

Mainframe98 updated the task description. (Show Details)