Page MenuHomePhabricator
Create Task
Maniphest T178607

Align Page Previews' not logged in user settings dialog with dialogs elsewhere
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Volker_E
Oct 19 2017, 6:32 PM
Tags
Referenced Files
F10643696: Screen Shot 2017-11-06 at 15.09.31.png
Nov 6 2017, 3:22 PM
F10318422: T178607 Page previews _post - Wikipédia, a szabad enciklopédia - (Private Browsing) 2017-10-19.png
Oct 19 2017, 6:59 PM
F10318394: T178607 Page previews _post - Wikipédia, a szabad enciklopédia - (Private Browsing) 2017-10-19.png
Oct 19 2017, 6:58 PM
F10318266: T178607 Page previews _before - Wikipédia, a szabad enciklopédia - (Private Browsing) 2017-10-19.png
Oct 19 2017, 6:45 PM
Subscribers
ABorbaWMF
Aklapper
• bmansurov
Jdlrobson
• Niedzielski
• Nirzar
phuedx
Volker_E

Description

Current settings dialog shown to not-logged users are visually off compared to dialogs elsewhere.

Before (in Vector skin)After
T178607 Page previews _before - Wikipédia, a szabad enciklopédia - (Private Browsing) 2017-10-19.png (242×453 px, 18 KB)
T178607 Page previews _post - Wikipédia, a szabad enciklopédia - (Private Browsing) 2017-10-19.png (214×429 px, 20 KB)

Let's align for the good.

Details

SubjectRepoBranchLines +/-
Align anonymous settings dialog appearance with style guidemediawiki/extensions/Popupsmaster+20 -8
Customize query in gerrit

Event Timeline

Volker_E created this task.Oct 19 2017, 6:32 PM
Restricted Application added a project: UI-Standardization. · View Herald TranscriptOct 19 2017, 6:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E renamed this task from Align Popups' not logged in user settings dialog with dialogs elsewhere to Align Page Previews' not logged in user settings dialog with dialogs elsewhere.Oct 19 2017, 6:45 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Oct 19 2017, 6:58 PM
Volker_E updated the task description. (Show Details)
gerritbot subscribed.Oct 19 2017, 7:10 PM

Change 385223 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Popups@master] Align anonymous settings dialog appearance with style guide

https://gerrit.wikimedia.org/r/385223

gerritbot added a project: Patch-For-Review.Oct 19 2017, 7:10 PM
phuedx added a subscriber: • Nirzar.Oct 20 2017, 5:24 AM

Thanks for working on this, @Volker_E!

/cc @Nirzar for visibility.

Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.Oct 31 2017, 12:53 AM

There is a patch from @Volker_E so pulling into sprint for visibility.

Jdlrobson moved this task from To Do to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Oct 31 2017, 12:53 AM
ovasileva triaged this task as Medium priority.Oct 31 2017, 2:26 PM
• Niedzielski subscribed.Oct 31 2017, 5:08 PM

@Nirzar, are you happy with this styling change? We'd like to move forward with Volker's patch. @Jdlrobson's going to try to push this to staging soon.

• Nirzar added a comment.Oct 31 2017, 5:12 PM

yes! very happy

gerritbot added a comment.Oct 31 2017, 11:19 PM

Change 385223 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Align anonymous settings dialog appearance with style guide

https://gerrit.wikimedia.org/r/385223

Jdlrobson moved this task from Needs More Work to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Oct 31 2017, 11:21 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 1 2017, 12:00 AM
ABorbaWMF subscribed.Nov 3 2017, 6:01 PM

I am having some trouble finding this particular dialog. @Jdlrobson or @Volker_E, can someone help me with steps to repro?

Volker_E added a comment.Nov 3 2017, 6:09 PM

@ABorbaWMF It's a bit tricky, you have to be logged out, look in a private browser window for example at https://hu.wikipedia.org/wiki/Kezd%C5%91lap You'll see the settings cog icon on the Page Preview dialog.

ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Nov 4 2017, 12:19 AM

Ah yes, thank you @Volker_E
This looks fixed on the beta cluster.

phuedx reassigned this task from Volker_E to • Nirzar.Nov 6 2017, 3:22 PM

@Nirzar: This is what I'm seeing on the Beta Cluster in Chrome (61.0.3163.100) on macOS Sierra (10.12.6).

Screen Shot 2017-11-06 at 15.09.31.png (208×437 px, 20 KB)

• Nirzar added a comment.Nov 6 2017, 9:35 PM

Macro votecat: looks good

• Nirzar closed this task as Resolved.Nov 6 2017, 9:35 PM
Volker_E claimed this task.Nov 9 2017, 9:43 PM
Volker_E moved this task from Backlog to Done on the UI-Standardization-Kanban board.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL