Move wiki revision path parameter to query parameter
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	Oct 19 2017, 7:31 PM

Description

Move the optional wiki page revision parameter to support wikipedia.org style revisions.

AC

The following URLs are supported:

http://localhost:3000/wiki/0/0?oldid=773367189 (page "0/0" at revision 773367189)
http://localhost:3000/wiki/0/0 (page "0/0" at the latest revision)
http://localhost:3000/wiki/0 (page "0")

Titles with unencoded question marks are still unsupported:

http://localhost:3000/wiki/?

Details

	Subject	Repo	Branch	Lines +/-
	Update: change revision path param to oldid query param	marvin	master	+98 -106

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	ovasileva	T176958 Display article content within article namespace
Declined	None	T173317 Initial version of article rendering
Resolved	• Niedzielski	T178616 Move wiki revision path parameter to query parameter
Resolved	• Niedzielski	T178615 Add query parameter typing
Resolved	• Niedzielski	T178617 Add query parameter parser

Event Timeline

• Niedzielski created this task.Oct 19 2017, 7:31 PM

• Niedzielski added a subtask: T178615: Add query parameter typing.

• Niedzielski mentioned this in T178617: Add query parameter parser.Oct 19 2017, 7:38 PM

• Niedzielski created subtask T178617: Add query parameter parser.

• Jhernandez awarded a token.Oct 20 2017, 9:14 AM

• Niedzielski updated the task description. (Show Details)Oct 20 2017, 2:49 PM

• Niedzielski moved this task from Needs Triage to Backlog (Priority Descending) on the Marvin board.Oct 31 2017, 6:09 PM

• Niedzielski mentioned this in T177870: The router should handle all page titles.Dec 7 2017, 6:42 PM

• Niedzielski claimed this task.Dec 12 2017, 3:23 PM

Change 397860 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[marvin@master] Update: change revision path param to oldid query param

https://gerrit.wikimedia.org/r/397860

gerritbot added a project: Patch-For-Review.Dec 12 2017, 4:21 PM

• Niedzielski mentioned this in rMARV220e340d18bc: Update: change revision path param to oldid query param.Dec 12 2017, 4:26 PM

Regarding the patch:

http://localhost:3000/wiki/0/0?oldid=773367189 (page "0/0" at revision 773367189)

This redirects instead of showing the redirect page itself but it appears to be a RESTBase vs MediaWiki behavior. e.g.:

https://en.wikipedia.org/api/rest_v1/page/mobile-sections/0%2f0/773367189?redirect=false
https://en.wikipedia.org/w/?oldid=773367189

http://localhost:3000/wiki/0/0 (page "0/0" at the latest revision)
http://localhost:3000/wiki/0 (page "0")

These work.

http://localhost:3000/wiki/?

Just like MediaWiki, this doesn't work. We use the question mark to separate URL query parameters.

• Niedzielski mentioned this in rMARV858fe4de5da1: Update: change revision path param to oldid query param.Dec 15 2017, 8:25 PM

• Jhernandez closed subtask T178617: Add query parameter parser as Resolved.Jan 10 2018, 6:34 PM

• Jhernandez closed subtask T178615: Add query parameter typing as Resolved.

• Niedzielski mentioned this in rMARV463be712b4fc: Update: change revision path param to oldid query param.Jan 12 2018, 6:14 PM

• Niedzielski mentioned this in rMARVe531fdbcc724: Update: change revision path param to oldid query param.Jan 12 2018, 6:23 PM

• Jhernandez closed this task as Resolved.Jan 16 2018, 5:44 PM

Change 397860 merged by jenkins-bot:
[marvin@master] Update: change revision path param to oldid query param