#jump-to-nav margin elimination caused the indentation between the subtitle and the article content to disappear
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jack_who_built_the_house
	Oct 19 2017, 9:37 PM

Description

https://en.wikipedia.org/wiki/Falcon
Before / Expected:

Now / Actual:

The case in both Vector and Monobook (didn't check others).

Relevant commits: https://gerrit.wikimedia.org/r/384129, (earlier) https://gerrit.wikimedia.org/r/#/c/376879/

Details

Subject	Repo	Branch	Lines +/-
Revert #contentSub and #jump-to-nav margin changes	mediawiki/core	REL1_30	+0 -10
Revert #contentSub and #jump-to-nav margin changes	mediawiki/core	master	+0 -10
Revert #contentSub and #jump-to-nav margin changes	mediawiki/core	master	+0 -11

Customize query in gerrit

Related Objects

Mentioned In: T195256: Implement accessibility jump links with pure CSS
T181154: On some wikis, #jump-to-nav elements on Recent changes are overlapping the page title
Mentioned Here: T176444: #jump-to-nav top margin is too big

Event Timeline

Jack_who_built_the_house created this task.Oct 19 2017, 9:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2017, 9:37 PM

Jack_who_built_the_house added a project: Web-Team-Backlog (Design).Oct 19 2017, 9:45 PM

Jack_who_built_the_house updated the task description. (Show Details)

Fixing this, one must also consider that not all pages have the subtitle, so ‘Information for Falcon’ [1], for example, should not have any additional margin, like it was before this change was made.

[1]: https://en.wikipedia.org/wiki/Falcon?action=info

This is actually a major design breakage, as it's one of the most visible spots on the page, so I'll set the priority to "Unbreak Now!" in hope of drawing attention to it.

Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptOct 19 2017, 10:09 PM

Aha, I found the relevant task: T176444. So, it happened after this was merged.

Gentlemen, is what is seen on the screenshots something that you supposed to get? I don't quite remember what the indentation of #mw-content-text was before the "Remove contentSub from layout when empty" commit, but now it's waaay too close to the subtitle.

...Actually, the indentation was exactly the same before and after the linked commit. #contentSub's

margin: 0 0 1.4em 1em;

was accompanied by #jump-to-nav's

margin-top: -1.4em;
margin-bottom: 1.4em;

After the change, the hidden #contentSub was compensated by #jump-to-nav's

margin-top: 0;
margin-bottom: 1.4em;

Now #contentSub is gone, and both #jump-to-nav's margins also gone. No margin left.

Jack_who_built_the_house updated the task description. (Show Details)Oct 19 2017, 11:23 PM

Jack_who_built_the_house renamed this task from Hiding empty #contentSub caused the indentation between the subtitle and the article content to disappear to #jump-to-nav margin elimination caused the indentation between the subtitle and the article content to disappear.Oct 19 2017, 11:51 PM

This does not look good. suggest just reverting all of it instead.

Nemo_bis added a project: MediaWiki-User-Interface.Oct 20 2017, 2:50 PM

i've put in place a temporary workaround in en.wp for the weekend.

@TheDJ Did you place it inside @media screen block on purpose?

• Elitre subscribed.Oct 21 2017, 4:59 PM

Any plans to fix it before the next deploy?

Status of this UBN!?

Change 389282 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Revert #contentSub and #jump-to-nav margin changes

https://gerrit.wikimedia.org/r/389282

gerritbot added a project: Patch-For-Review.Nov 4 2017, 10:30 PM

Change 389282 merged by jenkins-bot:
[mediawiki/core@master] Revert #contentSub and #jump-to-nav margin changes

https://gerrit.wikimedia.org/r/389282

matmarex closed this task as Resolved.Nov 4 2017, 10:38 PM

matmarex claimed this task.

matmarex removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 4 2017, 11:00 PM

Liuxinyu970226 unsubscribed.Nov 5 2017, 1:56 PM

Change 396429 had a related patch set uploaded (by Kghbln; owner: Karsten Hoffmeyer):
[mediawiki/core@master] Revert #contentSub and #jump-to-nav margin changes

https://gerrit.wikimedia.org/r/396429

gerritbot added a project: Patch-For-Review.Dec 8 2017, 5:09 PM

Change 396431 had a related patch set uploaded (by Kghbln; owner: Karsten Hoffmeyer):
[mediawiki/core@REL1_30] Revert #contentSub and #jump-to-nav margin changes

https://gerrit.wikimedia.org/r/396431

Change 396429 abandoned by Bartosz Dziewoński:
Revert #contentSub and #jump-to-nav margin changes

Reason:
Wrong branch, see https://gerrit.wikimedia.org/r/396431

https://gerrit.wikimedia.org/r/396429

Legoktm added a project: MW-1.30-release.Dec 8 2017, 7:19 PM

Change 396431 merged by Bartosz Dziewoński:
[mediawiki/core@REL1_30] Revert #contentSub and #jump-to-nav margin changes

https://gerrit.wikimedia.org/r/396431

ReleaseTaggerBot added a project: MW-1.30-release-notes.Dec 8 2017, 8:00 PM

• Petar.petkovic mentioned this in T181154: On some wikis, #jump-to-nav elements on Recent changes are overlapping the page title.Jan 9 2018, 5:38 PM

MBinder_WMF moved this task from Design to 2017-18 Q2 on the Web-Team-Backlog board.Mar 6 2018, 6:44 PM

MBinder_WMF edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).

TheDJ mentioned this in T195256: Implement accessibility jump links with pure CSS.Jun 4 2018, 8:14 PM

#jump-to-nav margin elimination caused the indentation between the subtitle and the article content to disappearClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

#jump-to-nav margin elimination caused the indentation between the subtitle and the article content to disappear
Closed, ResolvedPublic
Actions