Page MenuHomePhabricator

Sometimes images are missing from the Electron PDF
Closed, ResolvedPublic

Description

Sometimes not all the images are downloaded and the page has to be reloaded and purged for the PDF to be rendered properly.

Was reported for: https://en.wikipedia.org/wiki/en:Template:Tsuen%20Wan%20Line%20RDT
At https://www.mediawiki.org/wiki/Topic:U08at90ido2loj5q

Reproduction criteria

  • for a number of browsers and operating systems, test whether images are downloaded using:
    • the browser print
    • download as PDF (Electron)
  • if time, perform exploratory testing to identify other articles with the bug.

Related Objects

Event Timeline

ovasileva added subscribers: Jdlrobson, ovasileva.

@Jdlrobson - pulling this back into the backlog as we've had a number of bug reports on this. Do we know why it was originally moved to tracking?

We're actively working on Chromium PDF as we want to abandon the ElectronPDF extension. IMHO, first, we need a spike to find a way to reproduce those issues.

I don't think it might be article-dependent – probably just a server timeout(?) or something if there are lots of different images and maybe if someone's connection is slow (though it should be rendered server-side). I haven't done any further testing, though.

@ovasileva I have been unable to reproduce this one. I tried on a bunch of browsers including firefox and chromium. I tried the example article and bunch of other articles with lots of images (ex. Barrack Obama). I also played with some slow connection, but so far I am still unable to reproduce.

(downloaded on 18 October)

@ABorbaWMF Maybe try testing using a VPN (e.g. to somewhere in East or Southeast Asia), or testing when there's a higher load on the WMF servers?

Testing using the PDF renderer.

Articles -
https://en.wikipedia.org/wiki/Tsuen_Wan_line
https://proton-beta.wmflabs.org/en.wikipedia.org/v1/pdf/Tsuen_Wan_line/letter/desktop

https://en.wikipedia.org/wiki/Dmitri_Torbinski
https://proton-beta.wmflabs.org/en.wikipedia.org/v1/pdf/Dmitri Torbinski/a4/desktop

https://en.wikipedia.org/wiki/Mini
https://proton-beta.wmflabs.org/en.wikipedia.org/v1/pdf/Mini/legal/desktop

So far I have not reproduced this using the PDF renderer. I also tried a host of articles while working on T195991. Marking this resolved for now. We will retest it once the final version is live on production.