Page MenuHomePhabricator
Create Task
Maniphest T178685

fromnotif=1 highlight can cause scrollbars to appear
Closed, ResolvedPublic
Actions

Description

As you resize the window down, scrollbars flicker in and out

image.png (344×999 px, 23 KB)

Example: https://www.mediawiki.org/w/index.php?title=Topic:U08urfahk3n865wx&topic_showPostId=u08w3kfx1ieazyxd&fromnotif=1#flow-post-u08w3kfx1ieazyxd

Details

SubjectRepoBranchLines +/-
Set highlight border to exact pixel value to avoid scrollbar flickermediawiki/extensions/Flowmaster+2 -1
Customize query in gerrit

Event Timeline

Esanders created this task.Oct 20 2017, 12:23 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 20 2017, 12:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Oct 20 2017, 12:29 PM

Change 385361 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Set highlight border to exact pixel value to avoid scrollbar flicker

https://gerrit.wikimedia.org/r/385361

gerritbot added a project: Patch-For-Review.Oct 20 2017, 12:29 PM
gerritbot added a comment.Oct 23 2017, 4:25 AM

Change 385361 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Set highlight border to exact pixel value to avoid scrollbar flicker

https://gerrit.wikimedia.org/r/385361

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 23 2017, 5:00 AM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Dec 6 2017, 1:50 AM
• jmatazzoni moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Etonkovidova subscribed.Dec 9 2017, 2:00 AM

@Esanders Strangely, I still see the issue in wmf.11, e.g. https://www.mediawiki.org/w/index.php?title=Topic:Tgui6l1dwlyihruh&topic_showPostId=tgui6l1fgqe5tyk9&fromnotif=1#flow-post-tgui6l1fgqe5tyk9. The master (betalabs) seems to be fine. And as far as I could see https://gerrit.wikimedia.org/r/385361 should be deployed to wmf.11.

Etonkovidova closed this task as Resolved.Dec 11 2017, 5:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL