Page MenuHomePhabricator
Create Task
Maniphest T178708

Update Wiktionary definition parsing to account for new (possibly nested) section tags
Closed, ResolvedPublic
Actions

Description

The current Wiktionary definition parsing algorithm assumes that sections are divided by <div> elements and not nested <section> elements.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Next gen definitions parsing, using section tagsmediawiki/services/mobileappsmaster+47 -55
Hygiene: split up definitions parsing into two implementationsmediawiki/services/mobileappsmaster+201 -3
Hygiene: rename parseDefinitions to parseDefinitionsUsingDivsmediawiki/services/mobileappsmaster+8 -4
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
Resolved• bearNDT178705 Prepare MCS for Parsoid section tags
Resolved• bearNDT178708 Update Wiktionary definition parsing to account for new (possibly nested) section tags
· · ·

Event Timeline

• bearND created this task.Oct 20 2017, 6:01 PM
• bearND removed a project: Parsoid.Oct 20 2017, 6:03 PM
• bearND moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Oct 20 2017, 6:26 PM
• bearND edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
• bearND claimed this task.Oct 25 2017, 12:03 AM
• bearND moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
gerritbot subscribed.Oct 25 2017, 5:29 AM

Change 386334 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Hygiene: rename parseDefinitions to parseDefinitionsUsingDivs

https://gerrit.wikimedia.org/r/386334

gerritbot added a project: Patch-For-Review.Oct 25 2017, 5:29 AM

Change 386335 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Hygiene: split up definitions parsing into two implementations

https://gerrit.wikimedia.org/r/386335

gerritbot added a comment.Oct 25 2017, 5:29 AM

Change 386336 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Next gen definitions parsing, using section tags

https://gerrit.wikimedia.org/r/386336

• bearND moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 25 2017, 5:33 AM
gerritbot added a comment.Oct 31 2017, 6:16 PM

Change 386334 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Hygiene: rename parseDefinitions to parseDefinitionsUsingDivs

https://gerrit.wikimedia.org/r/386334

gerritbot added a comment.Oct 31 2017, 6:18 PM

Change 386335 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Hygiene: split up definitions parsing into two implementations

https://gerrit.wikimedia.org/r/386335

gerritbot added a comment.Nov 7 2017, 8:33 PM

Change 386336 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Next gen definitions parsing, using section tags

https://gerrit.wikimedia.org/r/386336

• bearND moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Nov 8 2017, 3:08 AM
Stashbot mentioned this in T178706: Improve section parsing in mobile-sections endpoint.Nov 8 2017, 9:37 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-11-08T21:37:28Z] <bsitzmann@tin> Started deploy [mobileapps/deploy@00e60b2]: Update mobileapps to 8e82983 (T178706 T178708 T178333 T170692)

Stashbot mentioned this in T178333: Move RESTBase page summary logic to MCS.Nov 8 2017, 9:37 PM
Stashbot mentioned this in T170692: Return common URLs in summary API so clients do not have to perform bug prone string manipulation .
Stashbot added a comment.Nov 8 2017, 9:44 PM

Mentioned in SAL (#wikimedia-operations) [2017-11-08T21:44:40Z] <bsitzmann@tin> Finished deploy [mobileapps/deploy@00e60b2]: Update mobileapps to 8e82983 (T178706 T178708 T178333 T170692) (duration: 07m 12s)

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Nov 8 2017, 9:47 PM
• bearND closed this task as Resolved.Nov 9 2017, 3:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits