Page MenuHomePhabricator
Create Task
Maniphest T178906

Refactor the Searcher class and the SearchContext to allow easy code reuse
Closed, ResolvedPublic
Actions

Description

The Searcher class still has some code that is hard to re-use. We should refactor it bit to clean the states in the SearchContext, goal is to :

  • move to a central place the building of the rescore queries
  • limit state changes in the SearchContext to limit dirty sates
  • externalize most of elastic query building code out of the searcher class
  • externalize the search_request building code so it can be reused

Details

Show related patches Customize query in gerrit

Event Timeline

dcausse created this task.Oct 24 2017, 2:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2017, 2:48 PM
dcausse added projects: CirrusSearch, Discovery-Search (Current work).Oct 24 2017, 2:48 PM
Restricted Application edited projects, added Discovery-ARCHIVED, Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptOct 24 2017, 2:48 PM
dcausse claimed this task.Oct 24 2017, 2:48 PM
dcausse triaged this task as Medium priority.
dcausse moved this task from needs triage to Current work on the Discovery-Search board.
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot subscribed.Oct 24 2017, 2:52 PM

Change 386179 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/Wikibase@master] PrefixSearch don't use mergeRescore

https://gerrit.wikimedia.org/r/386179

gerritbot added a project: Patch-For-Review.Oct 24 2017, 2:52 PM
gerritbot added a comment.Oct 24 2017, 3:04 PM

Change 386026 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Externalize some query building code out of the Searcher class

https://gerrit.wikimedia.org/r/386026

gerritbot added a comment.Oct 24 2017, 3:04 PM

Change 386027 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Kill Searcher::getAndFilterExtraIndexes

https://gerrit.wikimedia.org/r/386027

gerritbot added a comment.Oct 24 2017, 3:04 PM

Change 386028 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Compute CirrusSearchExtraIndexBoostTemplates on the fly

https://gerrit.wikimedia.org/r/386028

gerritbot added a comment.Oct 24 2017, 3:04 PM

Change 386199 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] SearchContext should allow setting plain rescore profiles

https://gerrit.wikimedia.org/r/386199

gerritbot added a comment.Oct 24 2017, 3:04 PM

Change 386167 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Try to unify phrase rescore with RescoreBuilder

https://gerrit.wikimedia.org/r/386167

gerritbot added a comment.Oct 24 2017, 3:04 PM

Change 386168 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Minor cleanup to Search::buildSearch

https://gerrit.wikimedia.org/r/386168

gerritbot added a comment.Oct 24 2017, 3:04 PM

Change 386169 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Avoid manipulating the Searcher state when building the query

https://gerrit.wikimedia.org/r/386169

gerritbot added a comment.Oct 24 2017, 4:14 PM

Change 386216 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Externalize Searcher::buildSearch()

https://gerrit.wikimedia.org/r/386216

gerritbot added a comment.Oct 24 2017, 7:19 PM

Change 386026 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Externalize some query building code out of the Searcher class

https://gerrit.wikimedia.org/r/386026

gerritbot added a comment.Oct 24 2017, 7:23 PM

Change 386027 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Kill Searcher::getAndFilterExtraIndexes

https://gerrit.wikimedia.org/r/386027

gerritbot added a comment.Oct 24 2017, 7:23 PM

Change 386028 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Compute CirrusSearchExtraIndexBoostTemplates on the fly

https://gerrit.wikimedia.org/r/386028

gerritbot added a comment.Oct 24 2017, 9:47 PM

Change 386199 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] SearchContext should allow setting plain rescore profiles

https://gerrit.wikimedia.org/r/386199

gerritbot added a comment.Oct 25 2017, 7:25 PM

Change 386179 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] PrefixSearch don't use mergeRescore

https://gerrit.wikimedia.org/r/386179

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)).Oct 30 2017, 3:01 PM
gerritbot added a comment.Oct 31 2017, 11:35 AM

Change 387558 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Externalize comp suggest builder code

https://gerrit.wikimedia.org/r/387558

dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Oct 31 2017, 5:16 PM
gerritbot added a comment.Nov 1 2017, 6:28 PM

Change 386167 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Try to unify phrase rescore with RescoreBuilder

https://gerrit.wikimedia.org/r/386167

gerritbot added a comment.Nov 1 2017, 6:29 PM

Change 386168 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Minor cleanup to Search::buildSearch

https://gerrit.wikimedia.org/r/386168

gerritbot added a comment.Nov 1 2017, 6:41 PM

Change 386169 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Avoid manipulating the Searcher state when building the query

https://gerrit.wikimedia.org/r/386169

gerritbot added a comment.Nov 1 2017, 6:41 PM

Change 386216 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Externalize Searcher::buildSearch()

https://gerrit.wikimedia.org/r/386216

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)); removed MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)).Nov 1 2017, 7:00 PM
gerritbot added a comment.Nov 1 2017, 9:04 PM

Change 387558 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Externalize comp suggest builder code

https://gerrit.wikimedia.org/r/387558

dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Nov 2 2017, 10:40 AM
gerritbot added a comment.Nov 8 2017, 10:23 PM

Change 390162 had a related patch set uploaded (by EBernhardson; owner: DCausse):
[mediawiki/extensions/CirrusSearch@wmf/1.31.0-wmf.6] Try to unify phrase rescore with RescoreBuilder

https://gerrit.wikimedia.org/r/390162

gerritbot added a comment.Nov 8 2017, 10:33 PM

Change 390162 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.31.0-wmf.6] Try to unify phrase rescore with RescoreBuilder

https://gerrit.wikimedia.org/r/390162

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)); removed MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 8 2017, 11:00 PM
debt closed this task as Resolved.Nov 9 2017, 10:07 PM
debt subscribed.

so many check-ins, great job, @dcausse!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits