| • Whatamidoing-WMF | |
| Oct 24 2017, 6:16 PM |
| F10430659: image.png | |
| Oct 25 2017, 3:18 PM |
| F10416406: Screen Shot 2017-10-24 at 19.55.19.png | |
| Oct 24 2017, 6:57 PM |
| F10416314: Screen Shot 2017-10-24 at 19.34.43.png | |
| Oct 24 2017, 6:36 PM |
Reported by User:Awewewe at https://www.mediawiki.org/wiki/Topic:U0f0e2q1pncgjbfj
See https://commons.wikimedia.org/wiki/File:Links_problem.png for a screenshot. The link images are very wide and short. The aspect ratio is about 5:2, and I think it's meant to be 16:9 (or thereabouts).
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | DLynch | T178933 Images shown in the link tool are very short and wide at cswiki | |||
| Resolved | • matmarex | T178437 Make icon/indicator visibility handling several widget nesting levels proof |
How peculiar. It's even doing it for placeholder images. @matmarex Some kind of OOUI regression?
Change 386286 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MWInternalLinkContextItem: increase specificity to override OOUI changes
To confirm, I did some testing of OOUI releases, and that icons commit does seem to have been the cause after all. The patch fixes it by increasing the specificity of our overrides so they (particularly the height) apply again.
Change 386286 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWInternalLinkContextItem: increase specificity to override OOUI changes
Change 386308 had a related patch set uploaded (by Jforrester; owner: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.5] MWInternalLinkContextItem: increase specificity to override OOUI changes
Change 386309 had a related patch set uploaded (by Jforrester; owner: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.4] MWInternalLinkContextItem: increase specificity to override OOUI changes
Change 386309 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.4] MWInternalLinkContextItem: increase specificity to override OOUI changes
Mentioned in SAL (#wikimedia-operations) [2017-10-25T14:11:13Z] <matt_flaschen> 'Deployed T178933: MWInternalLinkContextItem: increase specificity to override OOUI changes'
Change 386308 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.5] MWInternalLinkContextItem: increase specificity to override OOUI changes
Mentioned in SAL (#wikimedia-operations) [2017-10-25T23:48:15Z] <legoktm@tin> Synchronized php-1.31.0-wmf.5/extensions/VisualEditor/modules/ve-mw/ui/styles/contextitems/ve.ui.MWInternalLinkContextItem.css: MWInternalLinkContextItem: increase specificity to override OOUI changes - T178933 (duration: 00m 50s)
