deployment-prep statsd hiera does not have port
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ottomata
	Oct 25 2017, 5:07 PM

Description

In https://github.com/wikimedia/puppet/commit/7545d070e72c9f1b63f9dba2fb2ebf012d4d955e, statsd was set in hieradata/labs/deployment-prep/common.yaml. In hieradata/labs.yaml, this has a port. In deployment-prep/common.yaml, it does not.

This caused jmxtrans to break, as it expects to see a port in the statsd URI given to it from hiera.

We should either:
A. Set a port on the deployment-prep/common.yaml statsd variable
OR
B. Remove statsd definition from deployment-prep/common.yaml, since it should be the same value from labs.yaml anyway

I'd go ahead and do this, but I don't want to break something else. @Joe, would it be safe to do B.?

Details

	Subject	Repo	Branch	Lines +/-
	Add statsd port to deployment-prep/common.yaml	operations/puppet	production	+1 -1

Customize query in gerrit

Event Timeline

Ottomata created this task.Oct 25 2017, 5:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2017, 5:07 PM

Ottomata added a project: Services.Oct 25 2017, 5:08 PM

• mobrovac edited projects, added Services (watching); removed Services.Oct 26 2017, 9:24 AM

yeah we just need to add the port, it's obviously an error.

Change 386687 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[operations/puppet@production] Add statsd port to deployment-prep/common.yaml

https://gerrit.wikimedia.org/r/386687

Change 386687 merged by Ottomata:
[operations/puppet@production] Add statsd port to deployment-prep/common.yaml

https://gerrit.wikimedia.org/r/386687

Ottomata closed this task as Resolved.Oct 26 2017, 7:21 PM

Ottomata claimed this task.

deployment-prep statsd hiera does not have portClosed, ResolvedPublicActions

Description

Details

Event Timeline

deployment-prep statsd hiera does not have port
Closed, ResolvedPublic
Actions