Currently, each pipeline creates its own document and, at various stages, the results of those parses need to be adopted by the main document.
We expect some performance gains by eliminating that work.
See https://gerrit.wikimedia.org/r/#/c/385312/
Also, there're a few instances where we have a dummyDoc to avoid string concatenation which should make use of it.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T261329 Prepare Parsoid for MW (ideally in 1.39) | |||
| Resolved | Arlolra | T248342 Parsoid Extension API for MediaWiki 1.36 | |||
| Resolved | Arlolra | T179082 Use one ownerDocument for the entire parse | |||
| Resolved | Arlolra | T221790 Parsoid extension API should use DOM fragments, not documents |
I think generally the pattern should be:
var df = env.ownerDocument.createDocumentFragment();
var tempBody = env.ownerDocument.createElement('body');
df.append(tempBody);
tempBody.innerHTML = "some string to parse";as opposed to:
var newDoc = domino.createDOMImplementation().createHTMLDocument(); newDoc.documentElement.innerHTML = "some string to parse";
This uses Document.createDocumentFragment for storage of a DOM tree which isn't directly linked into the document itself.
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/490654 identifies where all the docs are currently created.
Change 617282 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] One document to rule them all
Change 622425 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Remove special case for the html extension
Change 622425 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove special case for the html extension when unpacking
Change 625641 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a8
Change 625641 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a8
Change 617282 merged by jenkins-bot:
[mediawiki/services/parsoid@master] One document to rule them all
Change 635100 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12
Change 635100 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a12
Change 662672 had a related patch set uploaded (by Paladox; owner: Arlolra):
[mediawiki/services/parsoid@REL1_35] Remove special case for the html extension when unpacking
Change 662672 merged by jenkins-bot:
[mediawiki/services/parsoid@REL1_35] Remove special case for the html extension when unpacking
Change 677986 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/vendor@REL1_35] Update Parsoid to 0.12.2
Change 677986 merged by C. Scott Ananian:
[mediawiki/vendor@REL1_35] Update Parsoid to 0.12.2