Page MenuHomePhabricator

Dark mode textviews aren't visible
Closed, ResolvedPublic

Description

Some TextViews are white with white text, in dark mode. [From OTRS]

Screenshot_20171015-212538.png (2×1 px, 188 KB)

Screenshot_20171015-212520.png (2×1 px, 145 KB)

Event Timeline

@Sharvaniharan A couple of notes:

  • Do we know which article this is? (i.e. how is this reproduced?)
  • The bug title is a bit confusing: TextViews are native Android components, whereas this is just content in the WebView. This looks like a <table> that has a hard-coded white background color. This means that it should probably be tagged with wikimedia-page-library since the page-library is responsible for restyling html elements to match the light/dark theme.

@Dbrant This is an OTRS ticket and there are no reproducible steps. Since this is a page library issue , should I remove apps tag also along with adding a page library tag ?

Yep! Thanks.
And using my Karaoke powers, I'm able to deduce that the article in question is actually: https://en.wikipedia.org/wiki/Led_Zeppelin_III#Standard_edition

Niedzielski claimed this task.
Niedzielski subscribed.

Fixed in Wikipedia for Android v2.7.232-r-2018-04-17.

screenshot-2018-05-18-21-07-32-063687806.png (2×1 px, 260 KB)