| ABorbaWMF | |
| Oct 26 2017, 11:39 PM |
| F10907008: T179127 Pie Chart Dark.PNG | |
| Nov 20 2017, 10:18 PM |
| F10907009: T179127 Pie Chart Sepia.PNG | |
| Nov 20 2017, 10:18 PM |
| F10907006: T179127 Pie Chart Light.PNG | |
| Nov 20 2017, 10:18 PM |
| F10907007: T179127 Brick Chart Dark.PNG | |
| Nov 20 2017, 10:18 PM |
| F10907011: T179127 Brick Chart Sepia.PNG | |
| Nov 20 2017, 10:18 PM |
| F10907010: T179127 Brick Chart Light.PNG | |
| Nov 20 2017, 10:18 PM |
| F10457650: Simulator Screen Shot - iPhone X - 2017-10-26 at 14.46.34.png | |
| Oct 26 2017, 11:39 PM |
| F10457651: Simulator Screen Shot - iPhone X - 2017-10-26 at 14.46.43.png | |
| Oct 26 2017, 11:39 PM |
Found on 5.7.0 (1247)
Steps:
Expected result:
The colors and objects within the tables or graphs remain visible
Actual Result:
The colors and objects disappear
| PepsiCo Default | Dark | Sepia |
 |  |  |
Graphs anc charts Default|Dark|Sepia|
 |  |  |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • NHarateh_WMF | T179127 Graphs and Charts issues on Sepia and Dark modes | |||
| Invalid | None | T179723 [SPIKE] Investigate whether Parsoid output can help solve theming issues |
Unassigning myself and moving this to Blocked or Waiting as @Fjalapeno advised we hold off on implementing the only semi-reliable solution to investigate Parsoid output first and perhaps use that in a new service.
Created a subtask for a spike.
Screenshots of some of the complexity we may have to wrangle in our theming if we're not able to get graphs/charts css classes we can more easily target:
https://github.com/wikimedia/wikimedia-page-library/pull/96#issuecomment-341830324
The issues in the screenshots crop up because our current options for identifying graphs/chart elements to be excluded from theming are too broad and end up mis-identifying other non graph/chart elements too.
Testing on iPhone 7 (iOS 11.0.2) - Wikipedia app 5.8.0 (1264). As the screencaps show below this is still broken, such as that colors in pie charts and brick charts are still not showing in Sepia and Dark modes.
The cases caught by Nicholas are the ones we decided not to fix due to lack of reliable tags.