Page MenuHomePhabricator

Access "Add more information" link when inserting a template using keyboard only is very long and ultimately doesn't work
Closed, ResolvedPublic8 Estimated Story Points

Description

Feedback from the WIkiconvention FR.

When you insert or edit a template using VE and use keyboard only, access the "Add more information" link is very long:

  1. use tab to skip all fields that are mandatory, suggested or already inserted. You can have many, and each require two to three hits on Tab key (of documented or not).
  2. Access Show options. You have to know it it here you have to go, while the "Add more information" link will not be selected when you use tab
  3. Use Tab to skip "cancel"
  4. Use Tab to skip the inserted fields options list
  5. Use Tab to skip the add template option
  6. Use Tab to skip the add content option
  7. Now you can search. (tested by inserting [[fr:modèle:Ouvrage]], requires 35 hits on Tab search for a non required field)
  8. But you can't select any of the results.

Ways to fix that:

  • have the search field as the first option, to help finding the fields you want to action.
  • make the search results actionable by keyboard

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I don't think that's how it works? With Tab, you just never get to the "Add more information" field, unless you've already opened it by clicking on it.
Being able to select a result in that field is actually kinda important, because you either type the name of the parameter exactly how it's supposed to be, or an underscore makes a difference between a useless parameter and a working one.

Deskana set the point value for this task to 8.
Deskana added a project: Accessibility.
Deskana subscribed.

I don't think that's how it works? With Tab, you just never get to the "Add more information" field, unless you've already opened it by clicking on it.

Yes, it appears you just can't get to it using the tab button. The same problem also exists in the media dialogue, where you can't tab to the images, so there you can't even complete your action using just the keyboard.

Some of the tab-order problems are browser-specific. What browser/OS were you trying this in?

Some of the tab-order problems are browser-specific. What browser/OS were you trying this in?

Firefox last versions on Windows and Ubuntu, Chromium last version on Ubuntu.

I tried it in Chrome on a Mac, so this one doesn't seem to be browser/OS specific.

It appears that searching and selecting the results works now. But the "Add more information" button still inexplicably has tabindex="-1" and is not selectable by keyboard. As shown in the task description it is possible to reach the same form via the "Show options" button, but this is a long and non-obvious process for something very commonly used.

  1. But you can't select any of the results.

It appears that searching and selecting the results works now.

This was fixed in T253665 (you can navigate the list by arrow keys, and select by pressing Enter).

But the "Add more information" button still inexplicably has tabindex="-1" and is not selectable by keyboard. As shown in the task description it is possible to reach the same form via the "Show options" button, but this is a long and non-obvious process for something very commonly used.

The tabindex of -1 on that button is indeed inexplicable.

I found that 37f49963929fd70e90075f42a7631a0f14e275d4 added the button with 'tabIndex': -1, which was actually copied from other buttons in that dialog – and those other buttons lost their 'tabIndex': -1 in 652136d7121e4a899308f0b55e81fa6187d2eabc. We can only guess why the "Add more information" button was skipped in that patch, and your guess is as good as mine.

I think that the template dialog's sidebar was meant to be the keyboard-accessible way to add and delete parameters, and while that works, it's far from convenient.

I think we should just make the button keyboard-accessible, like the others.

Change 659986 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Remove tabindex="-1" from "Add more information" button in template dialog

https://gerrit.wikimedia.org/r/659986

Change 659986 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove tabindex="-1" from "Add more information" button in template dialog

https://gerrit.wikimedia.org/r/659986

ppelberg claimed this task.