[wmf.5] Wrong message "This tool does not work without JavaScript..." displayed for mobile site for Special:ContentTranslation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Oct 27 2017, 6:21 AM

Project Tags

Referenced Files

	F10685033: Screen Shot 2017-11-08 at 3.48.51 PM.png
	Nov 9 2017, 12:14 AM

	F10462298: IMG_3565.PNG
	Oct 27 2017, 6:21 AM

Subscribers

Description

When navigating to Special:ContentTranslation page on mobile site (e.g. ca.m.wikipedia.org/w/index.php?title=Special:ContentTranslation&campaign=contributionsmenu&to=ca), the page is displayed with a wrong message "This tool does not work without JavaScript. JavaScript is disabled, failed to work, or this browser is unsupported."

TypeError: Cannot set property 'activator' of null TypeError: Cannot set property 'activator' of null 
at createMainMenu

The content on the page is not displayed and the message is incorrect - the javascript was, in fact, enabled. To make Special:ContentTranslation work on mobile, I needed to switch to the desktop view on some other page. Deleting m from the url did not work - it aggressively re-directs to the mobile view.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Avoid JS warning in minerva skin	mediawiki/extensions/ContentTranslation	master	+9 -10
	Ensure all dashboard modules have mobile target	mediawiki/extensions/ContentTranslation	master	+26 -49

Customize query in gerrit

Related Objects

Mentioned Here: T180082: "The action you have requested is limited to users in one of the groups: $1." user warning

Event Timeline

Etonkovidova created this task.Oct 27 2017, 6:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2017, 6:21 AM

• Arrbee assigned this task to Nikerabbit.Oct 27 2017, 6:49 AM

• Arrbee moved this task from Needs Triage to Oct-Dec 2017 on the ContentTranslation board.

• Arrbee added a project: Language-2017-Oct-Dec.

createMainMenu might come from a gadget, as I could not find it with a grep.

Nikerabbit triaged this task as Medium priority.Nov 6 2017, 8:06 AM

Found it in https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/b0df6367c26d3aee454d0fa1a76ca32244697bcb/resources/skins.minerva.scripts.top/init.js

It seems we wgMinervaMenuData is not being set.

It turns out the warning is pretty much unrelated to the actual issue that some modules were not marked to be compatible with mobile view. I will fix that first.

Change 389423 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Ensure all dashboard modules have mobile target

https://gerrit.wikimedia.org/r/389423

gerritbot added a project: Patch-For-Review.Nov 6 2017, 8:40 AM

Change 389423 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Ensure all dashboard modules have mobile target

https://gerrit.wikimedia.org/r/389423

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 6 2017, 12:00 PM

Change 389511 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Avoid JS warning in minerva skin

https://gerrit.wikimedia.org/r/389511

Some additional observations:

ULS trigger does not work in mobile view. This requires changes in ULS. A new task?
In minerva the personal tools are formatted in ugly way. But @Petar.petkovic is working on re-doing them, so I guess that's fine.

Nikerabbit moved this task from In Progress to In Review on the Language-2017-Oct-Dec board.Nov 7 2017, 7:02 AM

Change 389511 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Avoid JS warning in minerva skin

https://gerrit.wikimedia.org/r/389511

Nikerabbit removed a project: Patch-For-Review.Nov 7 2017, 11:33 AM

Nikerabbit moved this task from In Review to QA on the Language-2017-Oct-Dec board.

Nikerabbit added subscribers: Amire80, Pginer-WMF.

Checked in ca.m,wiki (wmf.7) - the issue is fixed. There is an accidental bug T180082: "The action you have requested is limited to users in one of the groups: $1." user warning - pasting the url ca.m.wikipedia.org/w/index.php?title=Special:ContentTranslation&campaign=contributionsmenu&to=ca will display

Screen Shot 2017-11-08 at 3.48.51 PM.png (1,211×473 px, 52 KB)

I added two projects that bug: ContentTranslation (Backlog)
MobileFrontend (Backlog) - not sure to which the issue actually belongs.

Etonkovidova closed this task as Resolved.Nov 9 2017, 12:14 AM

Nikerabbit moved this task from QA to Done on the Language-2017-Oct-Dec board.Nov 9 2017, 7:44 AM

[wmf.5] Wrong message "This tool does not work without JavaScript..." displayed for mobile site for Special:ContentTranslationClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[wmf.5] Wrong message "This tool does not work without JavaScript..." displayed for mobile site for Special:ContentTranslation
Closed, ResolvedPublic
Actions