Page MenuHomePhabricator

CologneBlue.php may need code modernisation
Closed, DeclinedPublic

Description

Author: nsk

Description:
In bug # 15868 there is a comment about code imperfections which, although about a patch, in fact may also apply in CologneBlue.php, therefore the skin code may be in need of code modernisation.


Version: 1.14.x
Severity: enhancement

Details

Reference
bz15929

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 10:21 PM
bzimport added a project: MediaWiki-Interface.
bzimport set Reference to bz15929.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Oct 10 2008, 3:26 PM

karun.84 wrote:

Patch reusing code from nostalgia

Ive modernised it based on the content of bug # 15868, and reused the code from r43182 from Nostalgia.

Attached:

What this patch does is to replace to the top links:

  • Main Page | About | Help | FAQ | Special pages | Log out (or Log in)

with

  • Main Page | Recent changes | Edit this page | Userpage | User talk |

Watchlist | My contributions | Preferences | Logout

All of the above links are already available from the left-hand side
sidebar, we don't need to copy Monobook here.

Second thing this patch does is to replace collecting of menu items
in an array and then joining them with a separator with plain string
concatenation. Personally I prefer the functional style of the original
code.

Danny_B removed a subscriber: wikibugs-l-list.