FlaggedRevs switches out publishpage/publishchanges (or save… equivalents) with revreview-submitedit. It does this through the EditPageBeforeEditButtons hook, with the changeSaveButton method in FlaggablePageView that has a lot of fragile, ugly hackery to just replace two configured message keys.
Can we "just" sub-class EditPage, replace getSubmitButtonLabel (to do this more neatly), and provide it out as an API for client editors somehow?
Change 387348 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView::changeSaveButton: Use OOUI methods to over-write
Subclassing EditPage is probably a bad idea in this case, as it will break everything else that needs to override EditPage (c.f. TwoColConflict). We should probably provide a hook to override getSubmitButtonLabel().
Change 387348 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] FlaggablePageView::changeSaveButton: Use OOUI methods to over-write
OK, so now everything is as before for users, but the code is a bit better. It's still going through the EditPageBeforeEditButtons hook, so still inaccessible through the API. Ideas?