[BUG] No background image when using "Share as image" on Chinese articles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cooltey
	Oct 30 2017, 10:20 PM

Description

Steps to reproduce

Pick any article which has a leading image
- e.g. : https://en.wikipedia.org/wiki/United_States
Change the article to either Traditional or Simplified Chinese
Long pressing on the texts, and click on "Share"

Expected

Texts with background image

Actual

Texts without background image

Details

	Subject	Repo	Branch	Lines +/-
	Fix: No background image when using "Share as image"	apps/android/wikipedia	master	+1 -1

Customize query in gerrit

Event Timeline

cooltey created this task.Oct 30 2017, 10:20 PM

Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptOct 30 2017, 10:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

cooltey claimed this task.Oct 30 2017, 11:08 PM

Change 387493 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: No background image when using "Share as image"

https://gerrit.wikimedia.org/r/387493

gerritbot added a project: Patch-For-Review.Oct 30 2017, 11:17 PM

Change 387493 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: No background image when using "Share as image"

https://gerrit.wikimedia.org/r/387493

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.22x-Fortune-Cookie on the Wikipedia-Android-App-Backlog board.Oct 31 2017, 1:43 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie); removed Wikipedia-Android-App-Backlog.

Dbrant moved this task from To Do to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie) board.Oct 31 2017, 2:21 PM

Tested on Wikipedia app 2.6.206/2016-11-01, 5.1 ZTE Maven (Z812), share a fact image does not appear to be available on this particular device so someone with a Samsung Galaxy series should also check.

Tested on 2.6.206-alpha-2017-11-02 on a Pixel and Nexus 4. Looks good to me.

Screenshot_20171102-131703.png (1×1 px, 863 KB)

RHo moved this task from Design Signoff to Ready for Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie) board.Nov 23 2017, 4:35 PM

Dbrant closed this task as Resolved.Nov 30 2017, 8:23 PM

Shizhao moved this task from Backlog to Closed on the Chinese-Sites board.Dec 1 2017, 3:05 AM

	F10575865: Screenshot_20171102-131703.png
	Nov 2 2017, 8:18 PM

[BUG] No background image when using "Share as image" on Chinese articlesClosed, ResolvedPublicActions