Maniphest T179509

id string in ORES does not include "features"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Halfak
	Nov 1 2017, 4:42 PM

Tags

Referenced Files

None

Subscribers

Description

This means two requests -- one for features and one for the basic score -- will use the same ID string and that causes ORES to barf.

Related Objects

Mentioned In: Blog Post: Status Update (January 30, 2018)
rORESe209d40d2940: Differentiate the task_id if features are requested
rORESdb1f9ff9797e: Differentiate the task_id if features are requested
T179873: KeyError on "features"
rORESa79d09e958bd: Differentiate the task_id if features are requested

Event Timeline

Halfak created this task.Nov 1 2017, 4:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2017, 4:42 PM

We can cherry-pick if needed, https://github.com/wiki-ai/ores/commit/a79d09e958bd28369d6040d4f07021392ff94810

awight mentioned this in rORESa79d09e958bd: Differentiate the task_id if features are requested.Nov 3 2017, 1:11 PM

LGTM.

awight mentioned this in T179873: KeyError on "features".Nov 6 2017, 10:05 PM

awight mentioned this in rORESdb1f9ff9797e: Differentiate the task_id if features are requested.Nov 13 2017, 9:10 PM

awight mentioned this in rORESe209d40d2940: Differentiate the task_id if features are requested.Nov 28 2017, 5:15 PM

Cherry-picking while Celery 4 work is on hold.

https://github.com/wiki-ai/ores/pull/236

awight moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Nov 28 2017, 5:16 PM

awight moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Dec 1 2017, 2:40 PM

Halfak moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Dec 5 2017, 4:44 PM

Halfak assigned this task to awight.Dec 11 2017, 3:44 PM

awight mentioned this in Blog Post: Status Update (January 30, 2018).Jan 30 2018, 7:03 PM

Halfak closed this task as Resolved.Jan 30 2018, 8:31 PM