Page MenuHomePhabricator

Wikistats Bug: Menu to select projects doesn't work (sometimes?)
Closed, ResolvedPublic21 Estimated Story Points

Description

Using Mac chrome, follow these steps:

  1. Go to the main, "All projects page."
  2. Click in project selection menu at top and select Wikipedia. The menu reads "Wikipedia -" to invite you to add a language.
  3. Write the word "English" after the dash; this brings up a menu with the option "English Wikipedia" displayed.
  4. Select the option.

Expected outcome: stats displayed for English Wikipedia.
Actual outcome: nothing happens.

The problem appears to be intermittent. I don't know why. The one time the menu worked for me, it worked only for the first selection. So lin the event you do get stats for English Wikipedia by following the steps above, repeat the process by selecting Italian, Spanish, etc.

Event Timeline

jmatazzoni renamed this task from Wikistats Bug: Menu to select projects doesn't work to Wikistats Bug: Menu to select projects doesn't work (sometimes?).Nov 1 2017, 7:35 PM
jmatazzoni added a subscriber: Jdforrester-WMF.

Hm, so far I've been able to reproduce on Mac Chrome. Any chance at all you get an error in the console @jmatazzoni ? I'm currently giving some love to the Wiki Selector and haven't come across this problem after a lot of playing with it.

Right now (Safari, MacBook Air), when I select Wikipedia and am prompted to choose a language, the list won't go beyond Bhojpuri (although I can type the one I'm looking for to make it appear and select it).

@Elitre yes, by design we limit the number of results on the wiki selector, so that the scroll bar remains usable and to encourage the user to use the search function.

well... I wonder if others would consider that as "broken" as I did, then. TY!

I'd forgotten I'd written this task, so redid it with the same results. On Mac Chrome, selecting a new language not on the menu doesn't work. Try the following:

  1. On Mac Chrome, go to the main Wikistats page.
  2. Click the top nav to go to the Contributing graph. The stat for "New Registered Users" on "All Project Families, All Languages" loads. (the bar graphs are at about 300k/mo)
  3. Click in the Wiki field and select Wikipedia. The field reads "Wikipedia —"
  4. Now start entering "English" after the dash. A menu appears, with "English Wikipedia" at the top.
  5. Select English Wikipedia from the menu.

Expected result: The graph updates with new figures
Actual result: The menu updates to read "Wikipedia — English," but the graph doesn't change. The figures remain those for All Projects and Languages.

I tried this on Mac Safari, and it worked at first, then it stopped working and started doing exactly what I describe above. I tried it in Firefox and it also didn't work.

The graph updates just fine if I actually pick from among the 20 or so languages starting with A and B that are offered at first in the menu.

Also, another annoying bug with the interface: When I've selected a project and language, and then switch metrics—from New registered users, say, to Edits—the menu reverts to All Projects All Families.

well... I wonder if others would consider that as "broken" as I did, then. TY!

I haven't understood the user experience described on the task description. Using a mouse, I'm expecting to have the possibility to scroll and find my language, as described on T182960: When searching for a project language, display a full list of languages. I don't expect to have a break in my workflow, switching from mouse to keyboard.

For the record, I'm copying from a mail exchange with @Milimetric :

The disadvantage is that the list becomes really hard to scroll through, almost impossible to reach the last items. And if it's all there, people might never think to type and search. But I agree it's probably a better default. We'll definitely circle back on all this as we go, we're not done with the interface by far.

Sometimes we get a dropdown box with "Which country are you from?" and we grumble if we can't type the first letter in a list of 200+ countries. Still scrolling is doable, but no fun.

Just an idea, but it may be too confusing: limit the list to 30 and filter the top 30 languages in terms of pageviews that match text typed: works also with no text typed. In the latter case, with no text typed, 30 languages will still satisfy say 98% of the queries.

Even more extreme, keep the list very short, say 10 items, and sort the languages by page views.

hm, that's interesting, we definitely could do that but I'm wondering if it'll hide the less popular wikis too much. I'll play with that and just making the list 200+ long.

@Erik_Zachte, just to be clear. In T179530#3839200 above, I'm not describing an interface problem (though I agree there is one). I'm describing an "I get no results, this is broken" problem.

I.e., when I start typing "English" it appears on the menu, but when I select that option, I do not get results for English. This is the problem that needs to be fixed before revising the interface

Ah, sorry I mixed up two tasks then. Just copied my comments to https://phabricator.wikimedia.org/T182960

I can reproduce the error in Ubuntu with both Chrome and Firefox.
Will look into that right now.

Change 402387 had a related patch set uploaded (by Mforns; owner: Mforns):
[analytics/wikistats2@master] [WIP] Improve WikiSelector

https://gerrit.wikimedia.org/r/402387

Fixed bugs/nits:

  • The one mentioned in the descriprion of this task
  • If you're typing and click outside the control, what you typed stays there
  • Separator long dash is replaced by a normal dash when selecting language
  • Special wikis like Meta have double names: Meta - Meta
  • Animation in case of long text is not showing all text. Ex: Belarusian (Tarasevika ...)
  • Arrow-scrolling keeps the highlighted option at the top of the box and flickers

Improvements:

  • The user can choose language, project family or special wiki in any order
  • The user can choose dbname and hostname shortcuts to choose wikis
  • Ordering of results prioritizes early matches and wide matches.
  • The WikiSelector reads 'Loading...' while sitematrix loads
  • Uses browser language to localize project family names.
  • Increases scroll limit to 500 to fit all project families, languages, and special wikis.

Change 402387 merged by Milimetric:
[analytics/wikistats2@master] Improve WikiSelector

https://gerrit.wikimedia.org/r/402387

mforns set the point value for this task to 21.Jan 19 2018, 5:03 PM

See: https://phabricator.wikimedia.org/T185334

I do not think we can both both offer all options to scroll plus offer localized search and have it be performant.

Performance issue solved and tracked separately