There's a lot of people that can review for the extension. That's not a problem.

Are there patches that need review that aren't receiving review?

There is T174667 for an example. But it just didn't seems like a lot of +2 reviewers was active. But I might have been to fast.

@Reedy - There is also two connected with this extension: https://gerrit.wikimedia.org/r/#/admin/groups/586,members - there are other people in the SWAT group that can as well, but they mostly do stuff like deployment on mediawiki projects.

In T179573#3732398, @SimmeD wrote:

@Reedy - There is also two connected with this extension: https://gerrit.wikimedia.org/r/#/admin/groups/586,members - there are other people in the SWAT group that can as well, but they mostly do stuff like deployment on mediawiki projects.

There's a lot more people than that, due to a variety of inheritance of rights

In T179573#3732828, @Reedy wrote:

In T179573#3732398, @SimmeD wrote:

@Reedy - There is also two connected with this extension: https://gerrit.wikimedia.org/r/#/admin/groups/586,members - there are other people in the SWAT group that can as well, but they mostly do stuff like deployment on mediawiki projects.

There's a lot more people than that, due to a variety of inheritance of rights

Where do I see who have +2 right then?

Starting with https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Newsletter,access

Directly, for the extension itself https://gerrit.wikimedia.org/r/#/admin/groups/586,members

It inherits from mediawiki/extensions https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions,access which in turn inherits from mediawiki https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki,access

The mediawiki group has quite a few people in it https://gerrit.wikimedia.org/r/#/admin/groups/11,members who can all CR+2

But are they active in this extension?

In T179573#3735433, @SimmeD wrote:

But are they active in this extension?

Why's that really matter? They're active over a lot of different extensions

In T179573#3735435, @Reedy wrote:

In T179573#3735433, @SimmeD wrote:

But are they active in this extension?

Why's that really matter? They're active over a lot of different extensions

If there are not active on this extension with code review, what can we use them for then?

Many of them, if asked, can/will review the code.

I think you're making an issue out of a problem that doesn't exist

In T179573#3735738, @Reedy wrote:

Many of them, if asked, can/will review the code.

I think you're making an issue out of a problem that doesn't exist

It's not my intension to make any problems. It's only becurse we had a patch that no one reviewed for 13 days. It's hard to develop on an extension if nobody helps with code review. But if they are active and we can contact them, then there might not be a problem. I might have been to hasty, for that I apologize, I'm only the kind of person that say his mind :-)

In T179573#3736019, @SimmeD wrote:

It's not my intension to make any problems. It's only becurse we had a patch that no one reviewed for 13 days. It's hard to develop on an extension if nobody helps with code review. But if they are active and we can contact them, then there might not be a problem. I might have been to hasty, for that I apologize, I'm only the kind of person that say his mind :-)

There's plenty of patches that haven't been reviewed for years.

See also T78768: Agree on and implement actions to prioritize code review of patches submitted by volunteers and T113707: Decision on Wikimedia Foundation service-level agreement on code review times

But I'm talking about local active +2 reviewers on this extension only? - If we have more local repo maintainers on this extension, then the development can continue without any lack of time, and we will also be able to develop without taking the time of SWAT members that other more important patches to review.

Other people than swat people can merge patches. Swat only happens a few times a day, during the week.

Most code review isn't done by the "local maintainers" anyway if we look across the many extensions

The other issue is that it's deployed on wmf wiki's. Therefore code should only be merged by trusted people. CR+2 won't be given out freely

As above, you seem to be looking for a solution to a problem that doesn't exist

Okay, then I'm going to close the task. Seems like everything is under control. It takes the time it takes then :-) - I diden't think about the fact that it will be deployed on other wikies. Of course people need to be trusted. My mistake.

See also https://wikitech.wikimedia.org/wiki/SWAT_deploys

I don't think there is a SWAT group of reviewers anyway. They only review the patches that are to be deployed in SWAT windows...