Rewind revscoring 1/2 compatibility hacks
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	awight
	Nov 2 2017, 6:05 PM

Description

After Revscoring 2 has been in production for a week or so, let's undo the nasty compatibility hacks.

Apply https://gerrit.wikimedia.org/r/#/c/383667/
Change Extension:ORES Stats::fetchStats memcache TTL from 1m -> 15m.

Details

	Subject	Repo	Branch	Lines +/-
	Revert "Fallback to old thresholds API as necessary (take 2)"	mediawiki/extensions/ORES	wmf/1.31.0-wmf.8	+4 -498
	Revert "Fallback to old thresholds API as necessary (take 2)"	mediawiki/extensions/ORES	master	+4 -498

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		awight	T175180 Deploy ORES (revscoring 2.0)
		Resolved		awight	T179602 Rewind revscoring 1/2 compatibility hacks

Event Timeline

awight created this task.Nov 2 2017, 6:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 2 2017, 6:05 PM

Change 383667 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Revert "Fallback to old thresholds API as necessary (take 2)"

https://gerrit.wikimedia.org/r/383667

gerritbot added a project: Patch-For-Review.Nov 14 2017, 7:29 PM

awight moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Nov 14 2017, 7:29 PM

Change 383667 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Revert "Fallback to old thresholds API as necessary (take 2)"

https://gerrit.wikimedia.org/r/383667

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 15 2017, 11:00 PM

Halfak moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Nov 20 2017, 5:51 PM

Halfak moved this task from Pending deployment to Parked on the Machine-Learning-Team (Active Tasks) board.

awight moved this task from Parked to Completed on the Machine-Learning-Team (Active Tasks) board.Nov 28 2017, 5:10 PM

awight closed this task as Resolved.Nov 28 2017, 5:41 PM

Noticed that this code isn't deployed yet.

It's actually causing some mischief, because we aren't correctly caching failures, so when the service is unavailable there's a cache stampede on every Special:RecentChanges request to hit model_info=test_stats, which 400's back at the client.

We could cherry-pick into wmf.8, or wait for the train to pick this up on Thursday.

+ 21ad7eefe3107a6a213987c043116d1f86dfe557 Revert "Fallback to old thresholds API as necessary (take 2)"

Change 393959 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@wmf/1.31.0-wmf.8] Revert "Fallback to old thresholds API as necessary (take 2)"

https://gerrit.wikimedia.org/r/393959

Change 393959 merged by jenkins-bot:
[mediawiki/extensions/ORES@wmf/1.31.0-wmf.8] Revert "Fallback to old thresholds API as necessary (take 2)"

https://gerrit.wikimedia.org/r/393959

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)); removed MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 29 2017, 1:01 AM

awight moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Dec 1 2017, 2:40 PM

awight mentioned this in Blog Post: Status Update (January 30, 2018).Jan 30 2018, 7:03 PM

Halfak closed this task as Resolved.Jan 30 2018, 8:31 PM