Revive ORES filters on Related Changes
Closed, ResolvedPublic
Actions

Description

Issues with the way the ORES search was implemented on Related Changes caused us to back the ORES functions out of that last April, as documented in T163063.

Related Changes is a surprisingly popular page, with an avg. 50K pvs per day on en.wiki. My understanding is that changes made since April may make it safe for the New Filters ORES tools (Edit Quality and User Intent filters) to be revived on Related Changed. If this is so, let's do it—after first evaluating whether it is, in fact, safe.

When we revive ORES on Releated Changes, the Recent Changes Revision Scoring preferences described in T180866 will control the page.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Enable ORES filters on RecentChangesLinked	mediawiki/extensions/ORES	master	+0 -19
	Tentatively re-enable ORES filters on RecentChangesLinked	mediawiki/extensions/ORES	master	+30 -12

Customize query in gerrit

Related Objects

Mentioned In: T134976: SpecialRecentChangesLinked::doMainQuery blocking database infrastructure
T180866: Rationalize ORES preferences on Recent Changes and Watchlist prefs pages
Mentioned Here: T180866: Rationalize ORES preferences on Recent Changes and Watchlist prefs pages
T163063: SpecialRecentChangesLinked::doMainQuery bad query bringing down database server

Event Timeline

• jmatazzoni created this task.Nov 3 2017, 6:35 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 3 2017, 6:35 PM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald Transcript

@Ladsgroup @Halfak @Catrope, do we think it's safe to bring these back? If so, should we do a test release of some type to make sure before releasing the features generally? If so, what type of test would you recommend?

• jmatazzoni lowered the priority of this task from Unbreak Now! to Medium.Nov 3 2017, 6:38 PM

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Nov 3 2017, 6:47 PM

Aklapper removed a project: MediaWiki-General.Nov 4 2017, 9:47 AM

We should be able to just bring this back, provided we first review and EXPLAIN the query to verify that it's now OK.

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Nov 21 2017, 12:29 AM

• jmatazzoni mentioned this in T180866: Rationalize ORES preferences on Recent Changes and Watchlist prefs pages.Dec 1 2017, 5:00 PM

• jmatazzoni updated the task description. (Show Details)

Ladsgroup moved this task from Incoming to Monitor on the User-Ladsgroup board.Dec 28 2017, 11:10 PM

Change 403479 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/ORES@master] Tentatively re-enable ORES filters on RecentChangesLinked

https://gerrit.wikimedia.org/r/403479

gerritbot added a project: Patch-For-Review.Jan 10 2018, 9:06 PM

SBisson claimed this task.Jan 10 2018, 9:22 PM

SBisson moved this task from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 403479 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Tentatively re-enable ORES filters on RecentChangesLinked

https://gerrit.wikimedia.org/r/403479

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 13 2018, 7:22 PM

@jmatazzoni, @Catrope ORES filters are now available on RecentChangesLinked (aka RelatedChanges) everwhere when using a special URL parameter (experimental_ores_on_rcl=1)

I have done some testing on popular pages with unlikely filters combination (very likely good faith + very likely have problems) and high limit and days values. Both highlight and filtering seem to work fine and be fast. I could not find any problem.

Feel free to try other combinations or pages that you think might be problematic.

Example: https://en.wikipedia.org/w/index.php?damaging=verylikelybad&goodfaith=likelygood&target=Donald+Trump&limit=500&days=30&title=Special:RecentChangesLinked&urlversion=2&experimental_ores_on_rcl=1

Trizek-WMF added a project: User-notice-collaboration.Jan 23 2018, 5:01 PM

Trizek-WMF moved this task from To Triage to Announce in next Collaboration Newsletter on the User-notice-collaboration board.

This comment has been deleted.

The ORES filters on Related Changes are not visible by default. They are hidden behind a private URL parameter (experimental_ores_on_rcl=1) while we check for performance issues.

@jmatazzoni If you repeat the steps above but reload Related Changes with &experimental_ores_on_rcl=1 at the end of the URL, you should see your preferences being applied. I just tried and it seemed ok on en.wp. Let me know if you see something different.

@Trizek-WMF please wait for this ticket to be resolved before announcing. This is currently in dark lunch (behind a private url flag) and we may need to revert if we find problems during testing.

In T179718#3921984, @SBisson wrote:

The ORES filters on Related Changes are not visible by default. They are hidden behind a private URL parameter (experimental_ores_on_rcl=1) while we check for performance issues.

D'oh! I knew that. Thanks Stephane. Looks good.

SBisson moved this task from Announce in next Collaboration Newsletter to Not ready to announce on the User-notice-collaboration board.Jan 25 2018, 10:32 PM

Change 406597 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/ORES@master] Enable ORES filters on RecentChangesLinked

https://gerrit.wikimedia.org/r/406597

I tested this on enwiki using a page with many outgoing links (Category:Living people), one with a moderate number (Albert Einstein) and one with few (() (disambiguation), yes that's a real page) and on all of them, performance didn't suffer at all from using an ORES filter. So let's do this.