I approve, naturally :-)

access to the servers where our services run on (e.g. hafnium for webperf/navtiming, and tungsten for xhgui - Note: host names to change per T158837).

Access is (should be) generally based on puppet role names, not host names. So in this case, this is:

• access to hosts using xhgui::app (admin groups in hieradata/role/common/xhgui/app.yaml = perf-roots)
• access to hosts using role::webperf (admin groups in hieradata/role/common/webperf.yaml = perf-roots, eventlogging-admins)

So we can summarize it as "membership in perf-roots" and access will move to wherever the role is applied which adds this group. We don't have to think about host names.

Though... Also see T179317#3731710 "perf-roots grants full root access to nearly half the servers in production"

@Muehlenhoff

In T179729#3736609, @Dzahn wrote:

Access is (should be) generally based on puppet role names, not host names.

Yeah, we use roles (mainly webperf and xhgui for the purpose of this task). And access to these roles will be granted via the perf-team group once T179728 is resolved, which should happen before this task. This is a request for perf-team (per task title).

@Krinkle Now that i saw the other ticket to create "perf-team" i understand better. Gotcha!

I've updated the title to reflect the recent creation of perf-team. I'll create a Gerrit patch, but this needs to be approved in next Monday's Ops meeting first.

Change 390244 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Add shell user for phedenskog

https://gerrit.wikimedia.org/r/390244

Change 390245 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Add phedenskog to perf-team group

https://gerrit.wikimedia.org/r/390245

Please note this was reviewed and approved in our operations team meeting today. I'll go ahead and rebase/merge @MoritzMuehlenhoff's patchsets.

Change 390244 merged by RobH:
[operations/puppet@production] Add shell user for phedenskog

https://gerrit.wikimedia.org/r/390244

Change 390245 merged by RobH:
[operations/puppet@production] Add phedenskog to perf-team group

https://gerrit.wikimedia.org/r/390245