Page MenuHomePhabricator

Phlogiston task_on_date should be refactored to use date, not datetimetz
Open, Needs TriagePublic20 Story Points

Description

Currently uses datetimestamp with time data discarded, such as 20170501 0:00:00 UT. but all calculations treat this as a date, so there is a lot of conversion code, which may be inconsistent, and there are lots of opportunities for fencepost errors, such as where midnight is counted. There are also a few "day + 1" hacks in the code. All of this should be eliminated in favor of treating all timestamps from Phabricator as dates only. This will change a core database table column and be a big refactor.

The most visible consequence of this is that the Status report start and end cutoffs are very confusing, which leads to difficulty validating the report because a sample task may be done in Phabricator on a certain day but not be reflected as expected in the Status report.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2017, 10:57 PM

Currently uses datetimestamp with time data discarded, such as 20170501 0:00:00 UT. but all calculations treat this as a date, so there is a lot of conversion code, which may be inconsistent, and there are lots of opportunities for fencepost errors, such as where midnight is counted. There are also a few "day + 1" hacks in the code. All of this should be eliminated in favor of treating all timestamps from Phabricator as dates only. This will change a core database table column and be a big refactor.

JAufrecht updated the task description. (Show Details)Nov 3 2017, 11:00 PM
JAufrecht set the point value for this task to 20.