When accessing a file description page, if the img_metadata field contains a:0:{}, it gets refreshed and populated.
This may be problematic since it's updating the database on an HTTP GET.
Steps to reproduce:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| filerepo: only trigger maybeUpgradeRow() on action=purge | mediawiki/core | master | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | aaron | T88445 MediaWiki active/active datacenter investigation and work (tracking) | |||
| Open | None | T92357 Fix database master queries from HTTP GET/HEAD before active-active multi-dc | |||
| Resolved | aaron | T179760 File metadata gets refreshed when accessing the file description page |
Tangently related, T32961: Run refreshImageMetadata.php --force (no, I'm not saying we just run the script instead of fixing this issue ;))
Multimedia team investigating to see if there's a problem or if this is intended functionality.
FWIW, there is explicitly a problem here; GET actions shouldn't be causing database writes
It looks like this is deferred until post-send, so there shouldn't be a user-visible latency impact. I'm assuming we're talking about LocalFile::maybeUpgradeRow().
Change 499988 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] filerepo: only trigger maybeUpgradeRow() on action=purge
Change 499988 merged by jenkins-bot:
[mediawiki/core@master] filerepo: only trigger maybeUpgradeRow() on action=purge