Hooks.php on line 602
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Addshore
	Nov 6 2017, 2:40 PM

Description

Seems similar to T164984

Every 2.0s: tail -n 1000 /srv/mw-log/hhvm.log |                                                                                                                                            Mon Nov  6 14:40:21 2017

    428 Notice: Undefined property: stdClass::$ores_damaging_threshold in /srv/mediawiki/php-1.31.0-wmf.6/extensions/ORES/includes/Hooks.php on line 602

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't use $row->ores_damaging_threshold in Contributions where it isn't set	mediawiki/extensions/ORES	master	+3 -1
	Protect Special:Contributions code from missing threshold	mediawiki/extensions/ORES	master	+4 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	PRODUCTION ERROR	awight	T179830 Notice: Undefined property: stdClass::$ores_damaging_threshold in /srv/mediawiki/php-1.31.0-wmf.6/extensions/ORES/includes/Hooks.php on line 602
		Declined		awight	T181666 Hide ORES filters from Special:Contributions when thresholds aren't available

Event Timeline

Addshore created this task.Nov 6 2017, 2:40 PM

Restricted Application added a project: Machine-Learning-Team. · View Herald TranscriptNov 6 2017, 2:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Addshore added a subscriber: Ladsgroup.Nov 6 2017, 2:41 PM

awight moved this task from Unsorted to Active Tasks on the Machine-Learning-Team board.Nov 8 2017, 7:20 PM

awight edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.

awight subscribed.

Change 390072 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/ORES@master] Don't use $row->ores_damaging_threshold in Contributions where it isn't set

https://gerrit.wikimedia.org/r/390072

gerritbot added a project: Patch-For-Review.Nov 8 2017, 7:20 PM

awight claimed this task.Nov 28 2017, 5:18 PM

Confirmed that this is still happening, although only in bursts:
https://logstash.wikimedia.org/goto/61a2074c6fef5cdef123efb14e106f00

These bursts correspond perfectly with service outages.

Strange, when I disable the ORES service locally and request Special:Contributions, the damaging threshold term is not included in the query (correct) and we never hit the line of code which is complaining (correct).

The checkbox for "hide good edits" should disappear but does not (bug).

awight created subtask T181666: Hide ORES filters from Special:Contributions when thresholds aren't available.Nov 29 2017, 7:12 PM

Change 394109 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Protect Special:Contributions code from missing threshold

https://gerrit.wikimedia.org/r/394109

awight moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Nov 29 2017, 7:13 PM

Change 394109 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Protect Special:Contributions code from missing threshold

https://gerrit.wikimedia.org/r/394109

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Nov 30 2017, 11:00 AM

Halfak moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Dec 4 2017, 3:07 PM

Halfak moved this task from Completed to Pending deployment on the Machine-Learning-Team (Active Tasks) board.

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Dec 15 2017, 12:21 AM

awight moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Dec 21 2017, 5:03 PM

awight mentioned this in Blog Post: Status Update (January 30, 2018).Jan 30 2018, 7:03 PM

Halfak closed this task as Resolved.Jan 30 2018, 8:31 PM

Harej closed subtask T181666: Hide ORES filters from Special:Contributions when thresholds aren't available as Declined.Mar 19 2019, 9:40 PM