Page MenuHomePhabricator

Recently added DIV wrapper around references needs DSR info to satisfy rountrip-test.js
Closed, ResolvedPublic

Description

Noticed in rt testing,

error/diff Bad dsr for DIV: <div class="mw-references-wrap mw-references-colum

likely from, https://github.com/wikimedia/parsoid/commit/92ecfd8896e7c64093d06a8f592d23350f0b605e

For example, node bin/roundtrip-test.js --prefix dewiki "Malaysia-Airlines-Flug 370"

Event Timeline

Arlolra triaged this task as Medium priority.Nov 6 2017, 5:54 PM
ssastry subscribed.

This is related to roundtrip-test.js with the double diff business and not part of regular dsr computation which is at some level can only get so precise. At one point, i would go through these and tweak roundtrip-test.js. If we want to do another pass at them, the parsoid logs on ruthenium will have a whole bunch of them to look at. Not worth a ticket for individual titles.

Not worth a ticket for individual titles.

I think this is an issue for every page with references. No dsr is set on the wrapper <div class="mw-references-wrap mw-references-colum and hits https://github.com/wikimedia/parsoid/blob/master/bin/roundtrip-test.js#L232-L249

ssastry renamed this task from Bad dsr for DIV to Recently added DIV wrapper around references needs DSR info to satisfy rountrip-test.js.Nov 6 2017, 6:23 PM
ssastry reopened this task as Open.
Arlolra claimed this task.