Page MenuHomePhabricator

[minor] Invalid page names are not detected in New translation dialog box
Closed, InvalidPublic

Description

The issue is minor - it's easy to correct an invalid page title after receiving the warning. However, it might be helpful for a user to receive the feedback on the invalid title earlier or to have more details (a link) on what characters for article titles are considered invalid.

  1. Start a new translation and enter the following name for the translated page: <<MediaWiki:Tag-foo-description>>
  2. 'New translation' dialog box does not give any warning to user.
  3. When a user tries to publish the translated page with the title <<MediaWiki:Tag-foo-description>>, a warning will be given 'The requested page title contains invalid characters'

Event Timeline

@Etonkovidova, is this about old "New translation" dialog (before T178866 was implemented) or about entering invalid characters as title for target page on translation view?
The problem on translation view is still there, but "New translation" dialog no longer allows entering target title. Another way to enter target title is through grey interlanguage links on some page with content, but I haven't checked that.

Here is how the error message looks when one tries publishing article with target title having invalid characters:

error-publishing-with-invalid-characters.PNG (696×108 px, 9 KB)

No indicator is shown beforehand, and there is no more info about which characters are invalid, although that might be obvious to most users.

We already check for this on front-end as well, and when invalid character is inserted in title, we get following message in the console: [CX] Invalid target title

@Pginer-WMF, @Amire80 what are your thoughts about this? Should we:

  1. display message earlier (before user tries to publish)?
  2. include helpful info which characters are invalid?
  3. both?
  4. something else?

Here is how the error message looks when one tries publishing article with target title having invalid characters:

error-publishing-with-invalid-characters.PNG (696×108 px, 9 KB)

No indicator is shown beforehand, and there is no more info about which characters are invalid, although that might be obvious to most users.

We already check for this on front-end as well, and when invalid character is inserted in title, we get following message in the console: [CX] Invalid target title

@Pginer-WMF, @Amire80 what are your thoughts about this? Should we:

  1. display message earlier (before user tries to publish)?
  2. include helpful info which characters are invalid?
  3. both?
  4. something else?

Ideally we should identify and communicate that the title is not valid as soon as possible. It is ok not to overreact when the title is empty (since the user may have deleted it to rewrite it), but as son as invalid characters apear it would be helpful to show a warning. If we could show the problematic characters highlighted in red in the title itself, that would be helpful to communicate which are the problematic characters.

Another approach could be to remove them as the user finishes editing the page title and show a warning that tells the user that invalid characters were removed.

As mentioned in the description, this seems a minor issue. So we may want to focus on other tickets first, but I'd be happy to explore solutions n more depth if we plan to work on this in the short term.

@Pginer-WMF, can you create a ticket for what you described in last comment?

This ticket should be closed as it is impossible to enter target title before translation view. There is one way to be more precise, but it involves playing with URL, so that should not be a concern.

@Pginer-WMF, can you create a ticket for what you described in last comment?

This ticket should be closed as it is impossible to enter target title before translation view. There is one way to be more precise, but it involves playing with URL, so that should not be a concern.

Closed. I created a follow-up ticket: T188982: CX2: Provide guidance to edit the translation title