Page MenuHomePhabricator
Create Task
Maniphest T179994

Link to action=edit of a specific revision shows current revision in VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This link was shared with me: https://www.mediawiki.org/w/index.php?title=User:Quiddity_(WMF)/sandbox&action=edit&oldid=2607307

However when I follow it, I see the current revision of that page. In order to go to the right revision, it needs veaction=editsource: https://www.mediawiki.org/w/index.php?title=User:Quiddity_(WMF)/sandbox&oldid=2607307&veaction=editsource

Not sure if this is expected behaviour?

Also discussed at https://www.mediawiki.org/wiki/Topic:U1d8xavtqmu1wgv9

Details

SubjectRepoBranchLines +/-
Preserve 'oldid' on custom edit pagemediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

MusikAnimal created this task.Nov 7 2017, 11:23 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 7 2017, 11:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MusikAnimal mentioned this in T179534: CodeMirror not recognizing Tableheaders on single text row.Nov 7 2017, 11:24 PM
Esanders renamed this task from Link to action=edit of a specific revision shows current revision in NWE to Link to action=edit of a specific revision shows current revision in VE.Nov 8 2017, 2:19 PM
Esanders removed a project: VisualEditor-MediaWiki-2017WikitextEditor.
Esanders subscribed.

This is not expected, nor is it specific to NWE...

gerritbot subscribed.Nov 8 2017, 2:42 PM

Change 389989 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Preserve 'oldid' on custom edit page

https://gerrit.wikimedia.org/r/389989

gerritbot added a project: Patch-For-Review.Nov 8 2017, 2:42 PM
• Deskana assigned this task to Esanders.Nov 9 2017, 2:05 PM
• Deskana triaged this task as Medium priority.
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
• Deskana set the point value for this task to 1.
gerritbot added a comment.Nov 10 2017, 6:22 PM

Change 389989 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Preserve 'oldid' on custom edit page

https://gerrit.wikimedia.org/r/389989

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)).Nov 10 2017, 7:00 PM
Jdforrester-WMF closed this task as Resolved.Nov 13 2017, 4:07 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 13 2017, 4:07 PM
Schnark merged a task: T180736: The (edit) link from old diff is opening the current version of the page.Nov 17 2017, 8:38 AM
Schnark added a subscriber: • Whatamidoing-WMF.
• Whatamidoing-WMF updated the task description. (Show Details)Nov 22 2017, 5:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL