Page MenuHomePhabricator

CentralAuthUser::loadFromCache doesn't call the makeKey() methods as needed
Closed, ResolvedPublic

Description

This missed in the various greps I did before 4432e898be07 was merged. It only has one key segment passed in (likely due to using dashes instead of colons), which would not happen if WANObjectCache::makeKey() was called. The method is also needed to handle engine-specific key limitations.

Nonsense entries like "MediaWiki.wanobjectcache.centralauth_user_fff1214d22d6cde50dbe5a95f1d328ac." need to also be deleted from graphite.

Event Timeline

aaron created this task.Nov 8 2017, 2:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2017, 2:50 AM

Change 389905 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/CentralAuth@master] Use the proper cache key method in loadFromCache()

https://gerrit.wikimedia.org/r/389905

Mentioned in SAL (#wikimedia-operations) [2017-11-08T05:45:08Z] <Krinkle> rm -rf /var/lib/carbon/whisper/MediaWiki/wanobjectcache/centralauth_user_* on graphite1001 and graphite2001 for T179999

Change 389917 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/extensions/CentralAuth@wmf/1.31.0-wmf.7] Use the proper cache key method in loadFromCache()

https://gerrit.wikimedia.org/r/389917

Change 389905 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Use the proper cache key method in loadFromCache()

https://gerrit.wikimedia.org/r/389905

Change 389917 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@wmf/1.31.0-wmf.7] Use the proper cache key method in loadFromCache()

https://gerrit.wikimedia.org/r/389917

Change 390076 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/CentralAuth@wmf/1.31.0-wmf.6] Use the proper cache key method in loadFromCache()

https://gerrit.wikimedia.org/r/390076

Change 390076 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@wmf/1.31.0-wmf.6] Use the proper cache key method in loadFromCache()

https://gerrit.wikimedia.org/r/390076

aaron closed this task as Resolved.Nov 8 2017, 8:35 PM