Hi @Dbrant , according to the documentation when Autosizing is enabled, this scales the text uniformly on horizontal and vertical axes, ignoring the text size attribute.

Now TextView for page title is using wrap_content with textSize of 28sp and maxLines = 3. With Autosizing we need a fixed size for the height. So, my question is, what is the fixed height we want to use for the title? Because, depending of this height the text will scale uniformly and we'll always have the whole title in one line.

I was doing some tests with a fixed height of 50dp, a minTextSize of 14sp and a maxTextSize of 28sp and these are the results with different lengths in the titles:

Title with short length

Examples with a long Title

Is this the expected result?

Also, try testing with some of these :)
https://en.wikipedia.org/wiki/Longest_word_in_English

thanks @TheDJ

I'll see how it look with this titles!

@RHo do you want a particular height for the title view, a particular minimum text size, or do you want me to play around?

Change 421458 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] [WIP] Autosizing textView for page title

https://gerrit.wikimedia.org/r/421458

In T180000#4074639, @Sharvaniharan wrote:

@RHo do you want a particular height for the title view, a particular minimum text size, or do you want me to play around?

Hi @Sharvaniharan - I think the minimum text size should be 24sp since I don't want the title text to appear smaller than H2 or H3s.
And to clarify, we want to allow wrapping across multiple lines still, is that correct?

Perhaps play around with the following long titles articles to start with:

• Lindsay Hassett with the Australian cricket team in England in 1948
• 中国人民政治协商会议第十三届全国委员会委员名单
• मण्डलशंकरपुर गाँव, फर्रुखाबाद (फर्रुखाबाद)
• Donaudampfschiffahrtselektrizitätenhauptbetriebswerkbauunterbeamtengesellschaft

@RHo here are a few examples with 24sp minimum and 28sp maximum: Textview height 120dp:

Min of 24sp only offers a slight improvement to current title without autosizing:

hi @Sharvaniharan - going back to the root issue, ie. allowing even very long article titles to be shown in their entirety, can we also remove or increase the current 3-line limit on the title?
This would be preferable than changing the font-size for the majority of shorter article titles.

@RHo I played around with different heights and the preset text sizes 24sp - 28sp with granularity of 1sp [decreaments of 1sp while trying to resize]. I see no best-fit scenarios at all.
-Cannot add ellipsis.
-Cuts off the last line of text in some cases
-If the height is increased, then the small titles start looking funny

• Even if you decide on a smaller text size, some long titles may still be rendered badly, getting cut-off on the last line..

This is at 19sp

I feel we should wait for the auto size support to get better. Meanwhile I can just increase the maxlines to be 4? I if we feel this is priority, I will invest some time to try and write a utility function to detect when the text is getting cut off, remove the not-fully-visible line and add an ellipsis instead..

per our discussion offline, we're removing the height restriction instead so titles take as much room as they need.

Not bad at all!

Change 423969 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Make entire title visible

https://gerrit.wikimedia.org/r/423969

Change 421458 abandoned by Sharvaniharan:
[WIP] Autosizing textView for page title

Reason:
Not using autosizing textview for now.

https://gerrit.wikimedia.org/r/421458

In T180000#4105471, @gerritbot wrote:

Not using autosizing textview for now.

I guess that would have bad consequences when "split screen" comes into play. Just try viewing the Lopadotemachosel... page while the app is open in split screen mode

Here's a screen shot of a page titled "2014 Japanese Grand pix" (I guess it isn't a very long name).

Change 423969 merged by jenkins-bot:
[apps/android/wikipedia@master] Make entire title visible

https://gerrit.wikimedia.org/r/423969

LGTM testing on Nexus 5 (6.0.1) on v2.7.231-alpha-2018-04-05

Long names looking good on 2.7.231-r-2018-0409