PHP Warning: Recursion detected in RequestContext
Closed, ResolvedPublic8 Estimated Story PointsPRODUCTION ERROR
Actions

Description

As seen in Logstash under mediawiki-errors for "Recursion detected", via https://logstash.wikimedia.org/goto/415180e45258ab2afdf73972a796d9fe.

Since MediaWiki 1.31.0-wmf.6, on at least ru.wikipedia.org and zh.wikipedia.org:

[{exception_id}] {exception_url} ErrorException from line 319 of /srv/mediawiki/php-1.32.0-wmf.13/includes/context/RequestContext.php: PHP Warning: Recursion detected in RequestContext::getLanguage

Recursion detected:
#0 /srv/mediawiki/php-1.32.0-wmf.13/includes/Message.php(380): RequestContext->getLanguage()
#1 /srv/mediawiki/php-1.32.0-wmf.13/includes/Message.php(1297): Message->getLanguage()
#2 /srv/mediawiki/php-1.32.0-wmf.13/includes/Message.php(849): Message->fetchMessage()
#3 /srv/mediawiki/php-1.32.0-wmf.13/includes/Message.php(953): Message->toString()
#4 /srv/mediawiki/php-1.32.0-wmf.13/includes/user/User.php(1888): Message->plain()
#5 /srv/mediawiki/php-1.32.0-wmf.13/includes/user/User.php(2274): User->getBlockedStatus()
#6 /srv/mediawiki/php-1.32.0-wmf.13/includes/user/User.php(2264): User->getBlock()
#7 /srv/mediawiki/php-1.32.0-wmf.13/includes/user/User.php(1370): User->isBlocked()
#8 /srv/mediawiki/php-1.32.0-wmf.13/includes/user/User.php(443): User->loadFromSession()
#9 /srv/mediawiki/php-1.32.0-wmf.13/includes/user/User.php(5456): User->load()
#10 /srv/mediawiki/php-1.32.0-wmf.13/includes/user/User.php(3146): User->loadOptions()
#11 /srv/mediawiki/php-1.32.0-wmf.13/includes/context/RequestContext.php(336): User->getOption()
#12 /srv/mediawiki/php-1.32.0-wmf.13/includes/StubObject.php(206): RequestContext->getLanguage()
#13 /srv/mediawiki/php-1.32.0-wmf.13/includes/StubObject.php(168): StubUserLang->_newObject()
#14 /srv/mediawiki/php-1.32.0-wmf.13/includes/parser/ParserOptions.php(956): StubObject->_unstub()
#15 /srv/mediawiki/php-1.32.0-wmf.13/extensions/TextExtracts/includes/ApiQueryExtracts.php(231): ParserOptions->__construct()
#16 /srv/mediawiki/php-1.32.0-wmf.13/extensions/TextExtracts/includes/ApiQueryExtracts.php(180): TextExtracts\ApiQueryExtracts->parse()
#17 /srv/mediawiki/php-1.32.0-wmf.13/extensions/TextExtracts/includes/ApiQueryExtracts.php(117): TextExtracts\ApiQueryExtracts->getExtract()
#18 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiQuery.php(249): TextExtracts\ApiQueryExtracts->execute()
#19 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(1582): ApiQuery->execute()
#20 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(535): ApiMain->executeAction()
#21 /srv/mediawiki/php-1.32.0-wmf.13/includes/api/ApiMain.php(506): ApiMain->executeActionWithErrorHandling()
#22 /srv/mediawiki/php-1.32.0-wmf.13/api.php(83): ApiMain->execute()
#23 /srv/mediawiki/w/api.php(3): include()
#24 {main}

Developer notes

From Max:
A quick solution would be to stick DeferredStringifier into block reason and pray that nothing relies too much on it being actual string. A more thorough one would be to refactor the crap from a lot of places: make Block internals hidden and accessible only via getters/setters, then add an option to initialize block reasons with messages that get fetched only when needed.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Defer cookie block checks to resolve a circular dependency	MaxSem	mediawiki/core	master	+92 -22

Customize query in gerrit

Related Objects

Mentioned In: T245231: Factor username logic out of the User class
T230153: WebResponse: Cannot modify header information - headers already sent by SpecialCentralAutoLogin.php
T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages
T226777: BlockManager->trackBlockWithCookie triggers "Recursion detected in RequestContext::getLanguage" warning
T180638: PHP Warning: Recursion detected in RequestContext::getLanguage during parse of variant
Mentioned Here: rMW1cc3a57296ff: Send a cookie with autoblocks to prevent vandalism.

Event Timeline

• Niedzielski created this task.Nov 8 2017, 5:12 PM

Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptNov 8 2017, 5:12 PM

Restricted Application added a subscriber: • Aklapper. · View Herald Transcript

This doesn't appear to be anything with Discovery-Search as we are asking for a global mediawiki object for the language, and it's been in place since 2015.

The relevant cirrus code here hasn't really changed since at least 2015. The stack trace seems a bit odd, i don't know this path much but it seems asking for the request language shouldn't require rendering i18n messages.

Shizhao added a project: Chinese-Sites.Nov 9 2017, 1:22 AM

So, basically, what's going on is:

Something needs user language
User information is loaded to get their language
Because cookie blocks are enabled, User::loadFromSession() retrieves block information
When there is a block not caused by something that an admin leaves a block message for (in this particular case, XFF but there are other similar cases around in User::getBlockedStatus()), we initialize the block message with an interface message:

$block->mReason = wfMessage( 'xffblockreason', $block->mReason )->text();

Message needs to know user language
Infinite loop!

A quick solution would be to stick DeferredStringifier into block reason and pray that nothing relies too much on it being actual string. A more thorough one would be to refactor the crap from a lot of places: make Block internals hidden and accessible only via getters/setters, then add an option to initialize block reasons with messages that get fetched only when needed.

Liuxinyu970226 added a project: Russian-Sites.Nov 9 2017, 1:01 PM

The proximate cause here seems to be rMW1cc3a57296ff: Send a cookie with autoblocks to prevent vandalism., which added attempted checking of the blocked status into User::loadFromSession().

• Niedzielski mentioned this in T180638: PHP Warning: Recursion detected in RequestContext::getLanguage during parse of variant.Nov 15 2017, 11:12 PM

kaldari edited projects, added: Language-Team; removed: Community-Tech.Nov 29 2017, 12:31 AM

There is no Language-Team. Besides, the cause has been diagnosed above and i18n is only tangentially related.

No justification in this task that this should block the release of MediaWiki 1.31.

Krinkle renamed this task from [Russian] [Chinese] PHP Warning: Recursion detected in RequestContext::getLanguage MW v1.31.0-wmf.6 to [Russian] [Chinese] PHP Warning: Recursion detected in RequestContext.Jul 31 2018, 6:24 PM

Krinkle updated the task description. (Show Details)

Restricted Application added a subscriber: Stang. · View Herald TranscriptJul 31 2018, 6:24 PM

All instances of this error seem to have in common that they are from /w/api.php requesting extracts.

Marking as production impact because it can cause incorrect results to be returned, given the user's language will not be considered during the request and likely other parser options may be incorrect as well, possibly causing cache poisoning.

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.Aug 1 2018, 1:03 AM

I think that should try to apply the first proposed solution (use the DeferredStringifier) and hope it fixes the problem.

ovasileva triaged this task as Medium priority.Aug 6 2018, 10:53 AM

pmiazga claimed this task.Aug 6 2018, 2:34 PM

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog-Archived board.Aug 9 2018, 9:28 PM

Jdlrobson updated the task description. (Show Details)Aug 9 2018, 9:43 PM

Jdlrobson set the point value for this task to 8.Aug 14 2018, 4:07 PM

Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Aug 23 2018, 10:40 PM

Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 16 2018, 7:08 PM

Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 1:09 AM

Liuxinyu970226 subscribed.Nov 6 2018, 1:23 PM

reflecting reality.

• debt unsubscribed.Nov 28 2018, 7:14 PM

Krinkle renamed this task from [Russian] [Chinese] PHP Warning: Recursion detected in RequestContext to [Russian] [Chinese] PHP Warning: Recursion detected in RequestContext in TextExtracts API.Jan 22 2019, 1:53 AM

Due to BlockManager changes, this has generated 256 errors in the last 15 minutes. Needs fixed ASAP. Also, removing irrelevant tags not related to the actual problem. It's neither restricted to ru: and zh:, nor does it have TextExtracts in its stacktraces.

Moral of the story: we should take care of our tech debt before it bites us in the ass.

MaxSem renamed this task from [Russian] [Chinese] PHP Warning: Recursion detected in RequestContext in TextExtracts API to PHP Warning: Recursion detected in RequestContext in TextExtracts API.Jun 26 2019, 5:59 AM

Change 519177 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] WIP: defer cookie block checks to resolve a circular dependency

https://gerrit.wikimedia.org/r/519177

gerritbot added a project: Patch-For-Review.Jun 26 2019, 6:01 AM

MaxSem renamed this task from PHP Warning: Recursion detected in RequestContext in TextExtracts API to PHP Warning: Recursion detected in RequestContext.Jun 26 2019, 7:02 AM

• Aklapper added a project: MediaWiki-User-management.Jun 26 2019, 8:34 AM

Tchanders added a project: Anti-Harassment-Team.Jun 27 2019, 10:06 AM

Restricted Application added a subscriber: MGChecker. · View Herald TranscriptJun 27 2019, 10:06 AM

Tchanders mentioned this in T226777: BlockManager->trackBlockWithCookie triggers "Recursion detected in RequestContext::getLanguage" warning.Jun 28 2019, 10:59 AM

Change 519177 merged by jenkins-bot:
[mediawiki/core@master] Defer cookie block checks to resolve a circular dependency

https://gerrit.wikimedia.org/r/519177

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2019, 11:10 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 1 2019, 1:00 PM

Tchanders mentioned this in T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.Jul 1 2019, 3:39 PM

Does https://gerrit.wikimedia.org/r/519177 fix this? I'm still catching up on a bunch of things, so am curious what the current state of this is..

@Jdlrobson Yes that should fix this - it hasn't been deployed yet, which is why the errors are still being logged.

JJMC89 moved this task from Backlog to User blocking on the MediaWiki-User-management board.Jul 10 2019, 4:36 PM

These appear to have tailed off. \o/

• Pchelolo mentioned this in T230153: WebResponse: Cannot modify header information - headers already sent by SpecialCentralAutoLogin.php.Aug 8 2019, 7:20 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM

dom_walden mentioned this in T245231: Factor username logic out of the User class.Mar 31 2020, 8:53 AM

• Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM

Stang unsubscribed.Nov 13 2021, 8:36 PM

PHP Warning: Recursion detected in RequestContextClosed, ResolvedPublic8 Estimated Story PointsPRODUCTION ERRORActions