Stop using composer class autoloading for "DataTypes" extension
Closed, InvalidPublic
Actions

Assigned To

Authored By

	Addshore
	Nov 8 2017, 6:40 PM

Description

In order to load this extension as a 'regular' extension in terms of the WMF deployment system the autoloader can not be generated by composer after cloning the git repo.
The class auto loading must be provided as part of the code contained in the git repo.

This could:

Be a committed version of the composer generator autoloader in a different location?
Be a list generated by the mediawiki core autoloader generating maint script?
Be something else

Interesting task to note is T99865: Extension registration should support using a PSR-4 autoloader but that is not done yet!

Details

Subject	Repo	Branch	Lines +/-
Explicitly load DataTypes extension	wikidata/build-resources	master	+8 -0
Use MediaWiki autoloader, and do not autoload the legacy entry point	mediawiki/extensions/DataTypes	master	+0 -9
Load DataTypes extension	operations/mediawiki-config	master	+4 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Addshore	T173818 [Epic] Kill the Wikidata build step
Resolved		Addshore	T175026 Remove extensions from the Wikidata build and deploy as a regular extension
Resolved		Addshore	T175025 Remove the "Wikibase" extension from the build and deploy as a regular extension
Resolved		Addshore	T180067 Stop using composer class autoloading for "Wikibase" extension
Resolved		Addshore	T175024 Remove the "WikibaseQuality" extension from the build and deploy as a regular extension
Resolved		WMDE-leszek	T180066 Stop using composer class autoloading for "WikibaseQuality" extension
Resolved		Addshore	T175022 Remove the "ArticlePlaceholder" extension from the build and deploy as a regular extension
Resolved		Legoktm	T180065 Stop using composer class autoloading for "ArticlePlaceholder" extension
Resolved		Addshore	T175023 Remove the "WikibaseQualityConstraints" extension from the build and deploy as a regular extension
Resolved		Addshore	T180064 Stop using composer class autoloading for "WikibaseQualityConstraints" extension
Resolved		Addshore	T180634 Bring extensions that were in the Wikidata build up to date with the code currently in the build for wmf.8 branch
Resolved		Addshore	T175021 Remove the "PropertySuggester" extension from the build and deploy as a regular extension
Resolved		Legoktm	T180063 Stop using composer class autoloading for "PropertySuggester" extension
Resolved		Addshore	T175019 Remove the "WikimediaBadges" extension from the build and deploy as a regular extension
Resolved		Legoktm	T180061 Stop using composer class autoloading for "WikimediaBadges" extension
Resolved		Addshore	T175018 Remove the "Wikidata.org" extension from the build and deploy as a regular extension
Resolved		Legoktm	T180060 Stop using composer class autoloading for "Wikidata.org" extension
Resolved		WMDE-leszek	T178739 Remove ValueView "extension" from the Wikidata build
Resolved		Addshore	T180539 wmf.8 still on old Wikidata branch
Resolved	PRODUCTION ERROR	daniel	T180605 Argument 1 passed to Wikibase\HistoryEntityAction::__construct() must be an instance of Article, WikiPage given in /srv/mediawiki/php-1.31.0-wmf.8/extensions/Wikidata/extensions/Wikibase/repo/includes/Content/ItemHandler.php on line 118
Invalid		Addshore	T180827 Bring extensions that were in the Wikidata build up to date with the code currently in the build for wmf.10 branch
Resolved		WMDE-leszek	T180454 Sort out the mess that is the DataTypes extension / library / npm packages in order to kill the build
Invalid		None	T175020 Remove the "DataTypes" extension from the build and deploy as a regular extension
Invalid		WMDE-leszek	T180062 Stop using composer class autoloading for "DataTypes" extension

Event Timeline

Addshore created this task.Nov 8 2017, 6:40 PM

This appears to be the case ever since rEDTY4304177f6584: Migrate to extension.json schema, but we need to stop autoloading the legacy PHP entry point.

we need to stop autoloading the legacy PHP entry point.

As in in WMF production?

Change 390231 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/DataTypes@master] Use MediaWiki autoloader, and do not autoload the legacy entry point

https://gerrit.wikimedia.org/r/390231

gerritbot added a project: Patch-For-Review.Nov 9 2017, 12:38 PM

Not sure if I did it right, I guess autoloading test classes with composer is still fine?

In T180062#3747597, @WMDE-leszek wrote:

Not sure if I did it right, I guess autoloading test classes with composer is still fine?

Hmm, probably not, otherwise tests loaded automatically by mediawiki that need those classes loaded wont have them loaded and will fail :/

Change 390337 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[wikidata/build-resources@master] Explicitly load DataTypes extension

https://gerrit.wikimedia.org/r/390337

WMDE-leszek mentioned this in rWDBR6ca292bc7c0f: Explicitly load DataTypes extension.Nov 9 2017, 10:44 PM

WMDE-leszek claimed this task.Nov 9 2017, 10:46 PM

Change 391029 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Load DataTypes extension

https://gerrit.wikimedia.org/r/391029

Addshore added a parent task: T180454: Sort out the mess that is the DataTypes extension / library / npm packages in order to kill the build.Nov 14 2017, 12:35 PM

@WMDE-leszek this is now invalid as DataTypes will no longer be an extension and the composer lib can keep the autoloading.

WMDE-leszek closed this task as Invalid.Nov 14 2017, 12:44 PM

Change 391029 abandoned by WMDE-leszek:
Load DataTypes extension

Reason:
DataTypes changed to be a regular PHP library. No longer an extension.

https://gerrit.wikimedia.org/r/391029

Change 390231 abandoned by WMDE-leszek:
Use MediaWiki autoloader, and do not autoload the legacy entry point

Reason:
DataTypes changed to be a regular PHP library. No longer an extension.

https://gerrit.wikimedia.org/r/390231

Change 390337 abandoned by Addshore:
Explicitly load DataTypes extension

Reason:
Build is dead