[BUG] Login and account creation screens allow user interaction while requests are processing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JoeWalsh
	Nov 8 2017, 10:13 PM

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

Simulate a slow connection with network link conditioner or LTE
Settings > Log in > Join Wikipedia
Enter valid information
Tap create your account

Expected results

Buttons and text fields are disabled while request processes. Errors are shown above the account creation VC.

Actual results

Able to tap create your account multiple times, edit text. Error messages are behind the account creation VC.

Related Objects

Mentioned In: rAPIOSfad84959a64b: Merge pull request #1939 from onlyrandomness/bug/T180078
rAPIOSb0554b79b9fb: Merge branch 'develop' into bug/T180078

Event Timeline

JoeWalsh created this task.Nov 8 2017, 10:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2017, 10:13 PM

JoeWalsh renamed this task from [BUG] Account creation screen allow user interaction while request is processing & error messages are missing to [BUG] Login and account creation screens allow user interaction while requests are processing.Nov 8 2017, 10:27 PM

• JMinor triaged this task as Low priority.Nov 13 2017, 7:10 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

Onlyrandomness claimed this task.Nov 19 2017, 11:05 AM

JoeWalsh mentioned this in rAPIOSb0554b79b9fb: Merge branch 'develop' into bug/T180078.Nov 27 2017, 11:59 AM

JoeWalsh mentioned this in rAPIOSfad84959a64b: Merge pull request #1939 from onlyrandomness/bug/T180078.Nov 27 2017, 12:22 PM

• NHarateh_WMF added a project: iOS-app-v5.7.4-Dachshund-On-An-Elk.Nov 27 2017, 2:19 PM

• NHarateh_WMF moved this task from Tasks from Product Backlog to Waiting for Build on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.

JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 27 2017, 8:05 PM

Looks great! Thanks @Onlyrandomness!

Testing on iPhone 6 Plus (iOS 11.1.2) and Wikipedia app 5.7.2 (1267) which was the latest update in TestFlight. According to the screencaps below, the error message shows at the top as expected, but it is still possible to tap "Create your account" during the "Saving..." process. Text fields are not disabled either.

This appears to be working on 5.7.3 (1281).

• JMinor closed this task as Resolved.Jan 8 2018, 10:39 PM

	F11207309: T1800781.PNG
	Dec 5 2017, 8:16 PM

	F11207308: T1800782.PNG
	Dec 5 2017, 8:16 PM

[BUG] Login and account creation screens allow user interaction while requests are processingClosed, ResolvedPublicActions