As per the epic,
This is a first small change so we can move towards a more comprehensive special page template
Proposed change
- Title alignment
- Title size
- Addition of a (optional) subtitle
Alignment
.pre-content.heading-holder h1 {
font-size: 24px;
margin-top:24px;
text-align: left;
}Addition of an optional subtitle
<h1>Settings</h1>
<p class="mw-mf-page-subtitle">Reading Preferences</p>
- This is an example of using these titles for Settings special page.
- This subtitle is optional for individual special pages, it can or cannot exist
With Subtitle
https://zpl.io/2Z0GrM4
Without subtitle
https://zpl.io/bPq0xyA
Before
After
Developer notes
All mobile special pages are subclasses of MobileSpecialPage and have a shared ResourceLoader module defined in mobile.special.styles, thus a change to the settings page heading will impact all pages. It would be sensible to thus work in a feature branch and focus on the Special:MobileOptions page. The side effects of this change can then be dealt with in later cards.
Alignment change
Changing the alignment should require a straightforward and simple change to styling rules mobile.special.styles (
New tagline "reading preferences"
This part will be require minor code changes in both Minerva and MobileFrontend.
- SkinMinerva::getTaglineHtml should be relaxed so that it will also render a description (if available) on special pages
- Inside the onSpecialPageBeforeExecute we can set a wikidata description using the special page name
$special->getOutput()->setProperty( 'wgMFDescription', 'Reading preferences' );
These two simple changes are all that needed.
AS part of this it might be tempting to rename MFDescription to MFTagline, but that should be considered going above and beyond!
