Page MenuHomePhabricator

Make AdvancedSearch a beta feature on de-wiki and ar-wiki
Closed, ResolvedPublic

Description

Motivation:
The AdvancedSearch project originates from WMDE's Technical Wishes project. More info can be found in German and in English.
It is now in a usable state, with some more functionality to come (e.g. deep category search). For giving feedback on the interaction and testing the already implemented keywords, it should become a beta feature on de-wiki.

Update: The ar-wiki community also requested a beta feature deploy, see T180291: beta test AdvancedSearch in Arabic Wikipedia

Time plan:
It is planned to be on dewiki and ar-wiki on the 29th Nov 2017
It is planned to make AdvancedSearch a beta feature for all wikis at the start of 2018, and to take it out of beta towards August 2018.

Background:
The AdvancedSearch project aims to make visible what search help exists already. It adds a form to the Special:Search page, where keywords and other search tools can be used through input fields.

Related Objects

Event Timeline

Restricted Application added a project: TCB-Team. · View Herald TranscriptNov 9 2017, 12:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lea_WMDE moved this task from Proposed to Todo on the WMDE-QWERTY-Team board.Nov 9 2017, 12:47 PM

@Lea_WMDE we need a sub ticket of this for deployment to group0 / test wikis before dewiki! :)

In the configuration there is still a section (that we need to add AdvancedSearch to) that says:

DO NOT add entries here without OK from Greg Grossmeier or James Forrester.

So ping @greg @Jdforrester-WMF, can we have an OK? :)
I seem to believe there is a checklist for beta features somewhere but I can't find it!

@Lea_WMDE you list T179272 & T179570 as "Must-haves before deploy".
Is this still the case? If so we should make these blockers of the deployment / this ticket.

In the configuration there is still a section (that we need to add AdvancedSearch to) that says:

DO NOT add entries here without OK from Greg Grossmeier or James Forrester.

So ping @greg @Jdforrester-WMF, can we have an OK? :)

Not until you link to the patches that fulfil the checklist. :-)

I seem to believe there is a checklist for beta features somewhere but I can't find it!

https://www.mediawiki.org/wiki/Beta_Features/Package

Have a quick chat with the product owner for Beta Features (currently James Forrester)

Does this count as 'the chat' or should @Lea_WMDE have a further chat with you?

Make an extension

https://www.mediawiki.org/wiki/Extension:AdvancedSearch
https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/AdvancedSearch,dashboards/default

Get preliminary design review

Done internally and I believe also reviewed by various WMF folks

Get preliminary security review

T168860: Security review for AdvancedSearch extension

Get preliminary performance review

Done internally? / T168860

Make sure there is a wiki page on MediaWiki.org for it that is understandable to the general public

I guess that would be https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/AdvancedSearch (also linked to from the extension page)

Ensure that the talk page for the project is using Flow[citation needed]

https://www.mediawiki.org/wiki/Extension_talk:AdvancedSearch ?

Make sure there is someone on point for feedback, acting as a product manager (either volunteer or WMF staff)

@Lea_WMDE

Make a Phabricator project for the extension

https://phabricator.wikimedia.org/project/view/2798/

Enable the "final version" of the code on Beta Cluster at least a week before you want to go for production.

Done (unless we want the 2 tickets I mention above done before deployment)

Make gerrit change (do not merge) to the Beta Features whitelist in mediawiki configuration

TODO (will attach the change to this ticket)

Deploy!

Change 390387 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Enable AdvancedSearch on dewiki

https://gerrit.wikimedia.org/r/390387

Addshore updated the task description. (Show Details)
Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 10 2017, 10:34 AM

Make sure there is a wiki page on MediaWiki.org for it that is understandable to the general public

I guess that would be https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/AdvancedSearch (also linked to from the extension page)

Explicitely for the beta feature, there will also be
https://www.mediawiki.org/wiki/Help:AdvancedSearch
https://www.mediawiki.org/wiki/Help_talk:AdvancedSearch
The texts exist as well, the writing was just stalled when we found the bugs on beta. If we fix the bugs quick enough to stay in our intended timeline, texts will be completed even before group0 deploy

Lea_WMDE renamed this task from Make AdvancedSearch a beta feature on de-wiki to Make AdvancedSearch a beta feature on de-wiki and ar-wiki.Nov 13 2017, 10:13 AM
Lea_WMDE updated the task description. (Show Details)

So it turns out the beta bugs were all bugs from beta, not AdvancedSearch :)
So we will finish off with T180335: Link from beta feature to help page on mediawiki.org
and apart from that only need your go, @Jdforrester-WMF :)

debt added a subscriber: debt.Nov 13 2017, 8:51 PM

Make sure there is a wiki page on MediaWiki.org for it that is understandable to the general public

I guess that would be https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/AdvancedSearch (also linked to from the extension page)

Explicitely for the beta feature, there will also be
https://www.mediawiki.org/wiki/Help:AdvancedSearch
https://www.mediawiki.org/wiki/Help_talk:AdvancedSearch
The texts exist as well, the writing was just stalled when we found the bugs on beta. If we fix the bugs quick enough to stay in our intended timeline, texts will be completed even before group0 deploy

Will there also be posts to the various email lists (ie: wikitech-l)? I'm excited to try out the beta! :)

Have a quick chat with the product owner for Beta Features (currently James Forrester)

Does this count as 'the chat' or should @Lea_WMDE have a further chat with you?

Totally. :-)

[Snip]

Get preliminary performance review

Done internally? / T168860

Mostly this is here for "are you going to melt the servers, and does Operations know". For WMDE we can consider this either met or that you know enough to de-deploy it if it breaks.

[Snip]

Make sure there is a wiki page on MediaWiki.org for it that is understandable to the general public

I guess that would be https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/AdvancedSearch (also linked to from the extension page)

Ensure that the talk page for the project is using Flow

https://www.mediawiki.org/wiki/Extension_talk:AdvancedSearch ?

As Lea says, per T180335 these should be to user-facing pages, not developer-facing ones.

[Snip]

Make gerrit change (do not merge) to the Beta Features whitelist in mediawiki configuration

TODO (will attach the change to this ticket)

Yay.

Once T180335 is done I'd consider this done.

Get preliminary performance review

Done internally? / T168860

Mostly this is here for "are you going to melt the servers, and does Operations know". For WMDE we can consider this either met or that you know enough to de-deploy it if it breaks.

Yep, I would consider this met, this is all JavaScript code adding functionality to search.
But there will likely be absolutely no visible impact on the servers.

[Snip]

Make sure there is a wiki page on MediaWiki.org for it that is understandable to the general public

I guess that would be https://meta.wikimedia.org/wiki/WMDE_Technical_Wishes/AdvancedSearch (also linked to from the extension page)

Ensure that the talk page for the project is using Flow

https://www.mediawiki.org/wiki/Extension_talk:AdvancedSearch ?

As Lea says, per T180335 these should be to user-facing pages, not developer-facing ones.
[Snip]

Make gerrit change (do not merge) to the Beta Features whitelist in mediawiki configuration

TODO (will attach the change to this ticket)

Yay.
Once T180335 is done I'd consider this done.

Great, as far as I know we are getting the pages / links updated today before the branch cut for the train!

Lea_WMDE updated the task description. (Show Details)Nov 14 2017, 9:59 AM

Will there also be posts to the various email lists (ie: wikitech-l)? I'm excited to try out the beta! :)

@debt yes, that's even the reason why we decided to postpone the deploy for a week, to have more time for a proper "this is going to be on mediawiki.org announcement" :)

and @Jdforrester-WMF thanks!

debt awarded a token.Nov 14 2017, 9:22 PM

Change 390387 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable AdvancedSearch on dewiki

https://gerrit.wikimedia.org/r/390387

Mentioned in SAL (#wikimedia-operations) [2017-11-29T14:07:01Z] <addshore@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT T180128 [[gerrit:390387|AdvancedSearch for dewiki]] (duration: 00m 50s)

Mentioned in SAL (#wikimedia-operations) [2017-11-29T14:10:52Z] <addshore@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT T180291 T180128 [[gerrit:393369|AdvancedSearch for arwiki]] (duration: 00m 49s)

Lea_WMDE moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Feb 20 2018, 3:33 PM