Open the template dialogue, e.g., to edit an infobox.
Scroll down and delete a parameter, (e.g., "image").
Watch the dialogue box scroll up to the top.
Wish that it stayed where it was, so you could delete the next parameter (e.g., "image width"), too.

Request made by @SpikeballUnion at https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2017_1#Deleting_infobox_parameters_scrolls_screen_to_top_of_dialogue_box See his screenshots that show the position before deleting the parameter and immediately after deleting it.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ve.ui.MWTemplateDialog: Prevent scrolling to top after removing a parameter	mediawiki/extensions/VisualEditor	master	+8 -5

Customize query in gerrit

Related Objects

Duplicates Merged Here: T197614: Removing parameters in VЕ backs to the beginning of the list of all parameters

Event Timeline

• Whatamidoing-WMF created this task.Nov 9 2017, 6:28 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 9 2017, 6:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reported again on mw.org. I can also reproduce.

And here...

• Deskana triaged this task as Medium priority.May 10 2018, 3:26 PM

• Deskana edited projects, added: VisualEditor (Current work); removed: VisualEditor.

Issue is subtle fallout from the async-promises change, I think?

ve.ui.MWTemplateDialog.prototype.onRemoveParameter calls this.bookletLayout.removePages(pages);
removePages (in OOUI) calls this.selectFirstSelectablePage();
onRemoveParameter then calls this.setPageByName( reselect.getName() );

There is a complicated mess of emitted events and queued animations, but the ultimate result seems to be that the initial "select first page" action happens, and the second "select closer page" doesn't. Or they do happen but out of order, maybe? Untangling the exact sequence is a pain.

• Elitre awarded a token.May 24 2018, 3:03 PM

matmarex merged a task: T197614: Removing parameters in VЕ backs to the beginning of the list of all parameters.Jun 21 2018, 6:15 PM

matmarex added subscribers: Aca, • Petar.petkovic, Kizule.

matmarex claimed this task.Jun 21 2018, 6:18 PM

Change 441424 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTemplateDialog: Prevent scrolling to top after removing a parameter

https://gerrit.wikimedia.org/r/441424

gerritbot added a project: Patch-For-Review.Jun 21 2018, 6:45 PM

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jun 21 2018, 6:47 PM

Change 441424 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWTemplateDialog: Prevent scrolling to top after removing a parameter

https://gerrit.wikimedia.org/r/441424

Jdforrester-WMF edited projects, added: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed: Patch-For-Review.Jun 25 2018, 5:50 PM

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.

• Petar.petkovic unsubscribed.Jun 25 2018, 5:53 PM

matej_suchanek awarded a token.Jun 26 2018, 2:22 PM

• Deskana closed this task as Resolved.Jun 26 2018, 2:42 PM

Ryasmeen added a project: Verified-in-Phase0.Jun 28 2018, 9:50 PM

ReleaseTaggerBot edited projects, added: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 30 2018, 4:01 PM

When you delete a parameter, the template dialogue box scrolls up to the top, and it should stay in the same placeClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

When you delete a parameter, the template dialogue box scrolls up to the top, and it should stay in the same place
Closed, ResolvedPublic
Actions