Steps to reproduce
- Run app in <= API 21 devices
- Read any article and try to long press to select texts
Expected
Able to see action buttons on the tool bar
Actual
Unable to see action buttons on the tool bar
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 391759 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Invisible toolbar icons in <= API21 - Update some icons with themed attribute - For v19 and v21 styles, srcCompact and android:src cannot be existed in the same time (otherwise will be crashed or does not work)
Comment Actions
Change 391759 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Invisible toolbar icons in <= API21 - Update some icons with themed attribute - For v19 and v21 styles, srcCompact and android:src cannot be existed in the same time (otherwise will be crashed or does not work)
Comment Actions
Nexus 4
Tested on 2.6.206-alpha-2017-11-29
I am not seeing the issue on the Pixel with Android 8.0, but I am able to reproduce it on the Nexus 4 with Android
Pixel
Nexus 4
Comment Actions
@ABorbaWMF
Thanks for the testing. Looks like you have different icons when selecting texts.
Could you please provide the Android version of the Nexus 4?
Comment Actions
Yes, it is on Android 5.1.1. I am trying to update it now, but it does not seem to want to update.
Comment Actions
Tested on AWS cloud testing service on the following devices:
- Samsung Galaxy S6 (Verizon) - Android 5.02=> able to reproduce
- Samsung Galaxy Note 4 (AT&T) - Android 5.01 => not able to reproduce
Comment Actions
Updated:
Test again on Samsung Galaxy S6 (Verizon) - Android 5.02, this time I am not able to reproduce.
Not sure what kind of situation will let the issue happen.
@ABorbaWMF
(No rush) If it is possible, could you please test it again on Nexus 4? (restart the phone and wipe the app)
Comment Actions
@cooltey Just to put in a passer by observation. Testing this on the latest alpha build (build dated 30-03-2018) on a Samsung Galaxy j2 running Android 5.1.1, I still observe the text selection icons becoming invisible issue. To be precise, the icons are visible when you select text but become invisible when you change the selection area using the selection pointers.
Comment Actions
Just to post another update I also observe the behaviour described in my previous comment on a Galaxy j1 ace (Android 5.1.1) when using the alpha version of the app dated 21-05-2018,
Comment Actions
I would like to add another update. on a Galaxy j1 ace.
Redundanct in text-selection menu
There is a redundancy in the text selection menu when the menu becomes transparent. There are two-ways to Share i) using the transparent icon ii) using the menu item from 'More options' overflow menu.
- Version 2.7.234-beta-2018-05-30
The transparent icon triggers the text sharing alone.While the one hidden in the 'More options' menu triggers the usual image-cum-text sharing.
- Version 2.7.234-alpha-2018-06-07
- In the File: pages in particular, only the transparent icon seems to work. The menu item doesn't work. The transparent icon triggers the text-sharing menu. The overflow-menu item doesn't trigger the image-cum-text sharing menu.
- In the File: pages in particular, the 'Define' overflow menu doesn't work. So, I'm unable to see definitions for words when I'm in File: pages. This doesn't happen in the beta app.