Change 404059 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Show message when article limit is reached on reading lists

https://gerrit.wikimedia.org/r/404059

Clarification needed on QA steps: Article 1K limit point 3: Should the message appear anytime any list with 1K articles is viewed, or only on the event that a user tries to add the 1001st article and immediately views the list?

Also, why are we even displaying the list with >1k articles to the bottom sheet as an option?

In T180230#3902600, @Sharvaniharan wrote:

Clarification needed on QA steps: Article 1K limit point 3: Should the message appear anytime any list with 1K articles is viewed, or only on the event that a user tries to add the 1001st article and immediately views the list?

The notification snackbar will be shown in both cases, but is a temporary message.

In T180230#3902607, @Sharvaniharan wrote:

Also, why are we even displaying the list with >1k articles to the bottom sheet as an option?

Do you mean the bottom sheet when a user tries to add an article to a list? It should still be visible since it would be unexpected and negative experience for the user if a list they've saved so many articles to seemingly disappears. So the intention here is to explicitly notify those users of this limit if they do ever reach that 1001st article, rather than inexplicably hiding the list.

Thanks for the clarification @RHo . I have made changes accordingly.

One more small clarification.. @RHo "Can't create another list. You've reached the limit of 100 lists reading lists per account." is it a typo "...100 lists reading lists..." should it be "...100 reading lists..."?

In T180230#3902762, @Sharvaniharan wrote:

One more small clarification.. @RHo "Can't create another list. You've reached the limit of 100 lists reading lists per account." is it a typo "...100 lists reading lists..." should it be "...100 reading lists..."?

Oops, yes it should be "100 reading lists" - just updated the description as well. Thanks!

Thank you..

@RHo another quick q:

1. Add 999 articles to a list
2. Add 2 articles to another list
3. Try to select both articles from second list and add it to the first one.

Right now, i have added logic to add articles only until we reach the limit, in this case, 1 article . However, the message shown in this case would be : Added 1 article to "first list". This message might be confusing to the user as they were expecting 2 articles to be added... can you give a message for this scenario?

For the sake of simplicity, can we just disallow adding X number of articles if if means that the list will exceed 1000 items, regardless of how many articles we want to add?

+1

Agree, let’s just display the same message regardless of the # of articles being added. Thanks!

https://youtu.be/vA6S73SExEI

@RHo Just to clarify, do we actually want to show a message when the user merely *navigates* to a list with 1000 items? (i.e. even when the user doesn't take any explicit action to add more articles to the list?)

Like, when the user opens the full-screen list activity with 1000 items, we show a message that says "Can't add to this list..."? My thought would be, "I wasn't trying to add anything."

Hey @Dbrant - This acts as reminder for the user in a similar way that there is a message when storage space is full. I want to err on showing this on the list view as a non-persistent notification rather than not, so it is always clear once the limit is reached why users will not be able to add more to the list.

Change 404059 merged by jenkins-bot:
[apps/android/wikipedia@master] Show message when article limit is reached on reading lists

https://gerrit.wikimedia.org/r/404059

LGTM on Nexus 5 (6.01), Wikipedia 2.7.224-alpha-2018-01-17

Articles per list exceeded message when trying to add to a 1000-article list		Lists exceeded message when trying to add to a an account with 100 lists already

Note for QA: Go to developer settings to auto-generate lists and create a list with X articles for testing.

Actually @Sharvaniharan - just noticed that these limits are being imposed for a user who has *NOT* opted-in to sync articles. @Dbrant - are we changing the expected behavior so that these limits are being imposed on everyone regardless of whether they opt in to sync?

Just s/w @Dbrant and updated task description that these limits are indeed imposed regardless of user syncing files or not.

LGTM on v2.7.224-alpha-2018-01-26

Limit size may change pending completion of T186296

Testing for new 5K limit

Looks fixed to me 2.7.226-alpha-2018-03-06