Page MenuHomePhabricator

VisualEditor: tall popup windows sometimes scroll target out of view
Closed, ResolvedPublic

Description

Edit the following test page with the visual editor:

https://www.mediawiki.org/wiki/Project:VisualEditor_testing/TestAxelBoldt?action=edit&oldid=2047299

Scroll down so that the word "link" in section "Regression 3" appears in the middle of the screen or higher. Highlight the word "link" and hit Ctrl-K to create a link. The resulting tall popup window causes the target word "link" to scroll out of view. Hitting Cancel or Done will not scroll the target back into view.

It appears that the target is out of view by just one line, so this looks like a classical off-by-one error.

This might be the same issue as T177660, but that report focuses on small screens while the issue reported here does not depend on screen size.

Event Timeline

This might be the same issue as T177660, but that report focuses on small screens while the issue reported here does not depend on screen size.

I think it is actually the same. I couldn't reproduce this at first because my screen is tall enough to fit the entire popup:

image.png (1×1 px, 296 KB)

But it happened exactly as described after I shrunk my browser a little bit:
image.png (967×1 px, 265 KB)

Esanders claimed this task.

The link stays in the viewport and the dropdown menu gets clippsed. Not sure when we fixed this.