Page MenuHomePhabricator
Create Task
Maniphest T180328

Add CI to all operations/dumps/* repositories and archive obsolete ones
Closed, DeclinedPublic
Actions

Description

There are 6 operations/dumps/* repositories in Gerrit that do not have CI. Some are probably obsoletes and could be marked archived, others surely could use some CI jobs to be added to them.

List of missing repositories.

RepositoryStatusComments
operations/dumps/dcat donePHP and i18n
operations/dumps/htmlLATERJavaScript. Canonical repo is https://github.com/wikimedia/htmldumper
operations/dumps/html/deployLATEREmpty, archive or delete?
operations/dumps/mwbzutils???C
operations/dumps/scapTODOScap configuration
operations/dumps/statusapi donePython, initial change is https://gerrit.wikimedia.org/r/#/c/335007/ . tox/flake8: https://gerrit.wikimedia.org/r/#/c/392037/

Nov 16th 2017, granted CI permission to submit patches on operations/dumps and its child.

Details

SubjectRepoBranchLines +/-
Add tox and pass flake8operations/dumps/statusapimaster+12 -5
operations/dumps/statusapi add toxintegration/configmaster+4 -0
Add PHP linteroperations/dumps/dcatmaster+33 -0
operations/dumps/dcat: composer for php lintingintegration/configmaster+1 -0
Add linters for i18n json filesoperations/dumps/dcatmaster+32 -1
operations/dumps/dcat: npm for jsonlint/bananaintegration/configmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Nov 13 2017, 9:52 AM
hashar mentioned this in T180330: Add CI to all operations/* repositories and archive obsolete ones.Nov 13 2017, 9:59 AM
hashar removed a project: Tracking-Neverending.
ArielGlenn added a comment.Nov 13 2017, 12:17 PM

My thoughts on CLI for these repos

  • dcat: YES
  • html: leave for now, it's not obsolete but nor do I have time to fix anything in there if it's broken, which I expect it is.
  • html/deploy: skip for now etc.
  • scap: YES
  • statusapi: leave for now, it's not obsolete but no time etc. There's a changeset in gerrit for it that won't get cleaned up and merged any time soon...
gerritbot subscribed.Nov 13 2017, 1:35 PM

Change 390993 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] operations/dumps/dcat: npm for jsonlint/banana

https://gerrit.wikimedia.org/r/390993

gerritbot added a project: Patch-For-Review.Nov 13 2017, 1:35 PM

Change 390994 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/dumps/dcat@master] Add linters for i18n json files

https://gerrit.wikimedia.org/r/390994

gerritbot added a comment.Nov 13 2017, 1:51 PM

Change 390998 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] operations/dumps/dcat: composer for php linting

https://gerrit.wikimedia.org/r/390998

gerritbot added a comment.Nov 13 2017, 1:52 PM

Change 390999 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/dumps/dcat@master] Add PHP linter

https://gerrit.wikimedia.org/r/390999

hashar triaged this task as Medium priority.Nov 13 2017, 1:55 PM
hashar updated the task description. (Show Details)
Lokal_Profil subscribed.Nov 13 2017, 2:07 PM
Lokal_Profil added a comment.Nov 13 2017, 3:59 PM

Are there other requirements which should be checked at the same time? E.g. presence of a LICENSE/COPYING file, CODE_OF_CONDUCT.md, assuming these are now requirements of gerrit repos.

gerritbot added a comment.Nov 16 2017, 8:13 PM

Change 390993 merged by jenkins-bot:
[integration/config@master] operations/dumps/dcat: npm for jsonlint/banana

https://gerrit.wikimedia.org/r/390993

hashar updated the task description. (Show Details)Nov 16 2017, 8:18 PM

In Gerrit, I have granted CI permission to submit patches on operations/dumps and its child.

gerritbot added a comment.Nov 16 2017, 8:25 PM

Change 390994 merged by jenkins-bot:
[operations/dumps/dcat@master] Add linters for i18n json files

https://gerrit.wikimedia.org/r/390994

hashar updated the task description. (Show Details)Nov 16 2017, 8:26 PM
gerritbot added a comment.Nov 16 2017, 8:27 PM

Change 390998 merged by jenkins-bot:
[integration/config@master] operations/dumps/dcat: composer for php linting

https://gerrit.wikimedia.org/r/390998

gerritbot added a comment.Nov 16 2017, 8:51 PM

Change 390999 merged by Hashar:
[operations/dumps/dcat@master] Add PHP linter

https://gerrit.wikimedia.org/r/390999

hashar updated the task description. (Show Details)Nov 17 2017, 11:57 AM
hashar added a comment.Nov 17 2017, 11:59 AM

html: leave for now, it's not obsolete but nor do I have time to fix anything in there if it's broken, which I expect it is.
html/deploy: skip for now etc.

The Gerrit repo operations/dumps/html seems to be maintained on https://github.com/wikimedia/htmldumper now. So I am tempted to just mark it read-only.

operations/dumps/html/deploy is empty. I guess we can just delete it.

operations/dumps/statusapi has pending change https://gerrit.wikimedia.org/r/#/c/335007/ . I guess I can amend it and add the basic tox / flake8 boiler plate to it and have CI to run tox.

hashar updated the task description. (Show Details)Nov 17 2017, 12:00 PM
gerritbot added a comment.Nov 17 2017, 12:10 PM

Change 392037 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/dumps/statusapi@master] Add tox and pass flake8

https://gerrit.wikimedia.org/r/392037

hashar updated the task description. (Show Details)Nov 17 2017, 12:11 PM
hashar mentioned this in rODSAb3aa944fb49b: Add tox and pass flake8.Nov 17 2017, 2:20 PM
gerritbot added a comment.Nov 20 2017, 3:20 PM

Change 392427 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] operations/dumps/statusapi add tox

https://gerrit.wikimedia.org/r/392427

gerritbot added a comment.Nov 20 2017, 3:21 PM

Change 392427 merged by jenkins-bot:
[integration/config@master] operations/dumps/statusapi add tox

https://gerrit.wikimedia.org/r/392427

gerritbot added a comment.Nov 20 2017, 3:24 PM

Change 392037 abandoned by Hashar:
Add tox and pass flake8

Reason:
squashed into https://gerrit.wikimedia.org/r/#/c/335007/

https://gerrit.wikimedia.org/r/392037

hashar updated the task description. (Show Details)Nov 20 2017, 3:26 PM
hashar edited projects, added Release-Engineering-Team (Kanban); removed Patch-For-Review.
hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.
greg moved this task from Backlog to Blocked (externally) on the Release-Engineering-Team (Kanban) board.Dec 18 2017, 5:42 PM
hashar closed this task as Declined.Aug 27 2018, 2:19 PM

Can be done later if there is any interest.

ArielGlenn moved this task from Backlog to Done on the Dumps-Generation board.Aug 31 2018, 8:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL