Page MenuHomePhabricator

Enable secondary actions on articles shown within On this day
Closed, ResolvedPublic

Assigned To
Authored By
RHo
Nov 13 2017, 6:50 PM
Referenced Files
F12637199: image.png
Jan 18 2018, 1:34 PM
F12637191: image.png
Jan 18 2018, 1:34 PM
F12637196: image.png
Jan 18 2018, 1:34 PM
F12011324: Screenshot_1514036759.png
Dec 23 2017, 1:57 PM
F11993138: Screenshot_1513954591.png
Dec 22 2017, 2:57 PM
F11977859: On this day - Inset article longpress initiated.png
Dec 21 2017, 8:11 PM
F11977863: On this day - Inset article longpress.png
Dec 21 2017, 8:11 PM
F11974124: Screenshot_1513875402.png
Dec 21 2017, 4:58 PM

Description

Background

This is a proposed enhancement to the original task of adding 'On this day' to the feed (see T175995).

User story

As a reader who likes to browse On this day content details, I want to easily save certain articles related to the events lists for reading later so that I can continue browsing through On this day uninterrupted.

Proposed solution

Long pressing on the inset article card allows users to take any action to add it to a reading list or share it.

Long press on inset article
On this day - Inset article longpress.png (1×720 px, 234 KB)
Long press initiates bottom sheet
On this day - Inset article longpress initiated.png (1×720 px, 136 KB)

The bottom sheet can re-use the same component built when tapping on overflows of articles saved to a reading list,

Proposal 2: Add a small overflow on each inset article card to allow share or adding to a reading list
^ Proposal 2 in practice results in very short strings on the inset article cards

Event Timeline

Change 399662 had a related patch set uploaded (by Jcasariego; owner: Jcasariego):
[apps/android/wikipedia@master] Add a small overflow on each inset article card within "On this day"

https://gerrit.wikimedia.org/r/399662

Hi @RHo , I was implementing the proposed solution with a small overflow on each inset article card.

This is how it looks with this change:

Screenshot_1513875402.png (1×1 px, 215 KB)

Screenshot_1513875397.png (1×1 px, 200 KB)

hi @Jcasariego - thanks for showing how this looks if using the overflow proposal. Looking at this in practice the very short strings on the inset article cards is not ideal, so have updated the task mocks for the other implementation whereby longpressing on the inset article cards brings up the secondary actions instead.

Great @RHo - I'll make an update using a long-press and I'll show you what it looks like.

This is how it looks using a long-press re-using the same component built when tapping on overflows

Screenshot_1513954591.png (1×1 px, 272 KB)

@RHo I didn't see the comment about re-using the same component built when tapping on overflows of articles saved to a reading list. I thought it was to use the same design that I used in the proposal 1. I'll see how is implemented and I'll update the design.

@RHo this is how it looks with the new component:

Screenshot_1514036759.png (1×1 px, 139 KB)

Thanks @Jcasariego - looks good to me from design perspective (assuming the icon colors will be fixed on T183495)!
Over to @Dbrant / @Sharvaniharan / @cooltey for code review.

Change 399662 merged by jenkins-bot:
[apps/android/wikipedia@master] Add actions on articles shown within "On this day"

https://gerrit.wikimedia.org/r/399662

LGTM on Nexus 5 (6.01), Wikipedia 2.7.224-alpha-2018-01-17

Long press on an article in the 'On this day' card in the Explore feed
image.png (1×1 px, 159 KB)
Long press on an article in the detailed On this day view
image.png (1×1 px, 302 KB)
Verified that articles are added by the 'Add' action
image.png (1×1 px, 511 KB)